[SPARK-16366][SPARKR] Fix time comparison failures in SparkR unit tests. #14046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #61727 has finished for PR 14046 at commit
|
| expect_equal(collect(select(df2, to_utc_timestamp(df2$b, "JST")))[, 1], | ||
| c(as.POSIXlt("2012-12-13 03:34:00 UTC"), as.POSIXlt("2014-12-14 16:24:34 UTC"))) | ||
| t <- c(as.POSIXlt("2012-12-13 21:34:00 UTC"), as.POSIXlt("2014-12-15 10:24:34 UTC")) | ||
| attr(t, "tzone") <- NULL |
There was a problem hiding this comment.
Do you know why we need this ? Doesnt the code to set time zone as UTC do the right thing ?
.originalTimeZone <- Sys.getenv("TZ")
Sys.setenv(TZ = "UTC")
There was a problem hiding this comment.
I do not have a deep understanding of time zone in R. let me spend some time to see if I can have a better fix. May need a look at date/time handling in serde.
|
@sun-rui Is this PR still active ? Can we close it if its not relevant ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix time comparison failures in SparkR unit tests. For details, refer to https://issues.apache.org/jira/browse/SPARK-16366.
How was this patch tested?
SparkR unit tests.