[SPARK-16369][MLlib] tallSkinnyQR of RowMatrix should aware of empty partition #14049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #61735 has finished for PR 14049 at commit
|
| partRows.foreach { row => | ||
| bdm(i, ::) := row.asBreeze.t | ||
| i += 1 | ||
| if (partRows.length == 0) { |
There was a problem hiding this comment.
Can you just flatMap this? so that you don't have to handle None below? or filter then map?
There was a problem hiding this comment.
Thanks! I changed it to filter then map.
|
Test build #61763 has finished for PR 14049 at commit
|
|
@yinxusen if you resolve the conflicts I'll merge. |
|
Test build #61932 has finished for PR 14049 at commit
|
|
Merged to master/2.0 |
asfgit
pushed a commit
that referenced
this pull request
Jul 8, 2016
…partition ## What changes were proposed in this pull request? tallSkinnyQR of RowMatrix should aware of empty partition, which could cause exception from Breeze qr decomposition. See the [archived dev mail](https://mail-archives.apache.org/mod_mbox/spark-dev/201510.mbox/%3CCAF7ADNrycvPL3qX-VZJhq4OYmiUUhoscut_tkOm63Cm18iK1tQmail.gmail.com%3E) for more details. ## How was this patch tested? Scala unit test. Author: Xusen Yin <yinxusen@gmail.com> Closes #14049 from yinxusen/SPARK-16369. (cherry picked from commit 255d74f) Signed-off-by: Sean Owen <sowen@cloudera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
tallSkinnyQR of RowMatrix should aware of empty partition, which could cause exception from Breeze qr decomposition.
See the archived dev mail for more details.
How was this patch tested?
Scala unit test.