[SPARK-16509][SPARKR] Rename window.partitionBy and window.orderBy to windowPartitionBy and windowOrderBy. #14192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… windowPartitionBy and windowOrderBy.
|
Test build #62292 has finished for PR 14192 at commit
|
| #' @note window.partitionBy(character) since 2.0.0 | ||
| setMethod("window.partitionBy", | ||
| #' @note windowPartitionBy(character) since 2.0.0 | ||
| setMethod("windowPartitionBy", |
There was a problem hiding this comment.
minor comment: Can we document the parameter @param col that is in all the 4 functions ? That'll also remove some of the CRAN warnings
|
Thanks @sun-rui for the PR. LGTM. I had a minor comment inline |
|
LGTM |
|
Test build #62297 has finished for PR 14192 at commit
|
|
LGTM. Merging this to master, branch-2.0 |
asfgit
pushed a commit
that referenced
this pull request
Jul 14, 2016
… windowPartitionBy and windowOrderBy. ## What changes were proposed in this pull request? Rename window.partitionBy and window.orderBy to windowPartitionBy and windowOrderBy to pass CRAN package check. ## How was this patch tested? SparkR unit tests. Author: Sun Rui <sunrui2016@gmail.com> Closes #14192 from sun-rui/SPARK-16509. (cherry picked from commit 093ebbc) Signed-off-by: Shivaram Venkataraman <shivaram@cs.berkeley.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Rename window.partitionBy and window.orderBy to windowPartitionBy and windowOrderBy to pass CRAN package check.
How was this patch tested?
SparkR unit tests.