Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-16657] [SQL] Replace children by innerChildren in InsertIntoHadoopFsRelationCommand and CreateHiveTableAsSelectCommand #14290

Closed
wants to merge 1 commit into from

Conversation

gatorsmile
Copy link
Member

What changes were proposed in this pull request?

The query in InsertIntoHadoopFsRelationCommand and CreateHiveTableAsSelectCommand should be treated as inner children, like what we did for the other similar nodes: CreateDataSourceTableAsSelectCommand, innerChildren, and InsertIntoDataSourceCommand.

The explain will be improved.
Before:

ExecutedCommand
:  +- CreateHiveTableAsSelectCommand [Database:default}, TableName: tab1, InsertIntoHiveTable]
:     +- Project [1 AS 1#13, 3 AS 3#14]
:        +- OneRowRelation$

After:

ExecutedCommand
:  +- CreateHiveTableAsSelectCommand [Database:default}, TableName: tab1, InsertIntoHiveTable]
:     :  +- Project [1 AS 1#13, 3 AS 3#14]
:     :     +- OneRowRelation$

How was this patch tested?

N/A

@SparkQA
Copy link

SparkQA commented Jul 21, 2016

Test build #62638 has finished for PR 14290 at commit e0605cd.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member Author

The analyzer resolution requires them as children. Although this is inconsistent with the other similar nodes, we still can tolerate it.

@gatorsmile gatorsmile closed this Jul 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants