Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SQL] Cleaned up ConstantFolding slightly. #1430

Closed
wants to merge 2 commits into from
Closed

[SQL] Cleaned up ConstantFolding slightly. #1430

wants to merge 2 commits into from

Conversation

rxin
Copy link
Contributor

@rxin rxin commented Jul 16, 2014

Moved couple rules out of NullPropagation and added more comments.

@rxin
[SQL] Cleaned up ConstantFolding slightly.
7f8cf61 
Moved couple rules out of NullPropagation and added more comments.
@SparkQA
Copy link

SparkQA commented Jul 16, 2014

QA tests have started for PR 1430. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16714/consoleFull

@chenghao-intel
Copy link
Contributor

The code looks good to me.
I am thinking if we could merge the ConstantFolding & NullPropagation and make it transformExpressionsUp , since they kind of rely on each other, and people may always get confused when place a Null or Constant optimization.

@rxin
Copy link
Contributor Author

rxin commented Jul 16, 2014

See the discussion at #1428.

@SparkQA
Copy link

SparkQA commented Jul 16, 2014

QA results for PR 1430:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16714/consoleFull

@rxin
Copy link
Contributor Author

rxin commented Jul 16, 2014

Merging in master & branch-1.0.

@asfgit asfgit closed this in 1c5739f Jul 16, 2014
@rxin
Copy link
Contributor Author

rxin commented Jul 16, 2014

Actually only master. There is a conflict in branch-1.0 that I will leave it intact for now.

@rxin rxin deleted the sql-folding-rule branch July 16, 2014 18:06
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@rxin @conviva-zz
[SQL] Cleaned up ConstantFolding slightly.
ac0a764 
Moved couple rules out of NullPropagation and added more comments.

Author: Reynold Xin <rxin@apache.org>

Closes apache#1430 from rxin/sql-folding-rule and squashes the following commits:

7f9a197 [Reynold Xin] Updated documentation for ConstantFolding.
7f8cf61 [Reynold Xin] [SQL] Cleaned up ConstantFolding slightly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rxin @SparkQA @chenghao-intel