[SPARK-16691][SQL] move BucketSpec to catalyst module and use it in CatalogTable #14331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @yhuai @liancheng |
| @@ -764,10 +761,7 @@ private[hive] class HiveClientImpl( | |||
| hiveTable.setFields(schema.asJava) | |||
| } | |||
| hiveTable.setPartCols(partCols.asJava) | |||
| // TODO: set sort columns here too | |||
| hiveTable.setBucketCols(table.bucketColumnNames.asJava) | |||
There was a problem hiding this comment.
we don't support bucketed hive table now, and I think we never will, because we have different hash implementation.
|
Test build #62763 has finished for PR 14331 at commit
|
|
LGTM |
|
Test build #62776 has finished for PR 14331 at commit
|
|
Test build #62777 has finished for PR 14331 at commit
|
| } | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Nit: Remove extra newline.
|
Overall LGTM, a few minor comments. |
|
Test build #62798 has finished for PR 14331 at commit
|
|
Test build #62821 has finished for PR 14331 at commit
|
|
Merging to master, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It's weird that we have
BucketSpecto abstract bucket info, but don't use it inCatalogTable. This PR movesBucketSpecinto catalyst module.How was this patch tested?
existing tests.