[SPARK-16710] [SparkR] [ML] spark.glm should support weightCol #14346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #62824 has finished for PR 14346 at commit
|
|
cc @mengxr |
|
cc: @junyangq |
| @@ -119,7 +121,7 @@ NULL | |||
| #' @note spark.glm since 2.0.0 | |||
| #' @seealso \link{glm}, \link{read.ml} | |||
| setMethod("spark.glm", signature(data = "SparkDataFrame", formula = "formula"), | |||
| function(data, formula, family = gaussian, tol = 1e-6, maxIter = 25) { | |||
| function(data, formula, family = gaussian, weightCol = NULL, tol = 1e-6, maxIter = 25) { | |||
There was a problem hiding this comment.
you might not want to add a parameter in the middle of the list. if someone has existing code calling this function in parameter order it might misalign
|
Test build #63081 has finished for PR 14346 at commit
|
|
LGTM |
1 similar comment
|
LGTM |
|
LGTM. Merging this to master. @mengxr @felixcheung I didn't merge this into branch-2.0 as having Scala + R changes could affect the CRAN package we are building to match the 2.0 release. We can do a round of backports after that is done if required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Training GLMs on weighted dataset is very important use cases, but it is not supported by SparkR currently. Users can pass argument
weightsto specify the weights vector in native R. Forspark.glm, we can pass in theweightColwhich is consistent with MLlib.How was this patch tested?
Unit test.