-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spark-16791] [SQL] cast struct with timestamp field fails #14400
Closed
eyalfa
wants to merge
6
commits into
apache:master
from
eyalfa:SPARK-16791_cast_struct_with_timestamp_field_fails
Closed
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
456de17
SPARK-16791_cast_struct_with_timestamp_field_fails: added a failing t…
f13113d
SPARK-16791_cast_struct_with_timestamp_field_fails: trivial fix.
a3b456c
SPARK-16791_cast_struct_with_timestamp_field_fails: fix style comment…
34fdb78
SPARK-16791_cast_struct_with_timestamp_field_fails: some more formatt…
6e7f69f
SPARK-16791_cast_struct_with_timestamp_field_fails: yet another forma…
e0549a9
SPARK-16791_cast_struct_with_timestamp_field_fails: remove one more e…
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -727,6 +727,19 @@ class CastSuite extends SparkFunSuite with ExpressionEvalHelper { | |
} | ||
} | ||
|
||
test("cast struct with a timestamp field") { | ||
val originalSchema = StructType( | ||
Seq(StructField( "tsField", TimestampType, nullable = false )) | ||
) | ||
val targetSchema = StructType( | ||
// nine out of ten times I'm casting a struct, it's to normalize its fields nullability | ||
Seq(StructField( "tsField", TimestampType, nullable = true )) | ||
) | ||
val inp = Literal.create(InternalRow(0L), originalSchema) | ||
val expected = InternalRow(0L) | ||
checkEvaluation(cast(inp, targetSchema), expected ) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and remove the extra space here too |
||
} | ||
|
||
test("complex casting") { | ||
val complex = Literal.create( | ||
Row( | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we usually use
new StructType().add("name", TimestampType, nullable = false)