[MINOR][SPARKR] Verbose build comment in WINDOWS.md rather than promoting default build without Hive #14890
Conversation
| @@ -4,13 +4,21 @@ To build SparkR on Windows, the following steps are required | |||
|
|
|||
| 1. Install R (>= 3.1) and [Rtools](http://cran.r-project.org/bin/windows/Rtools/). Make sure to | |||
| include Rtools and R in `PATH`. | |||
|
|
|||
There was a problem hiding this comment.
This spaces are necessary because without them it will markdown as below:
This spaces make this pretty as below:
|
Could you please check if this is sensible @shivaram and @felixcheung? |
|
Test build #64704 has finished for PR 14890 at commit
|
|
Test build #64706 has finished for PR 14890 at commit
|
|
Test build #64707 has finished for PR 14890 at commit
|
| mvn -DskipTests -Psparkr package | ||
| ``` | ||
|
|
||
| `.\build\mvn` is a shell script so `mvn` should be used directly on Windows. |
There was a problem hiding this comment.
shouldn't it be mvn.cmd on Windows?
https://maven.apache.org/guides/getting-started/windows-prerequisites.html
There was a problem hiding this comment.
Yes, it seems it'd be safer. Thanks for pointing this out.
|
Test build #64711 has finished for PR 14890 at commit
|
HyukjinKwon
changed the title
|
LGTM. Thanks @HyukjinKwon - Merging this to master |
What changes were proposed in this pull request?
This PR fixes
WINDOWS.mdto imply referring other profiles in http://spark.apache.org/docs/latest/building-spark.html#building-with-buildmvn rather than directly pointing to runmvn -DskipTests -Psparkr packagewithout Hive supports.How was this patch tested?
Manually,