[SPARK-11301][SQL] Fix case sensitivity for filter on partitioned col… #14970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @cloud-fan . |
|
Also, cc @yhuai . |
|
thanks, can you also put the reason of this bug in PR description(not just symptom)? Is it a bug for 1.6 only? |
|
Thank you for review, @cloud-fan . Yes. This is a bug for 1.6 branch only. I'll update the PR description. |
|
Test build #64977 has finished for PR 14970 at commit
|
|
@cloud-fan . I updated the PR description with the more detail reason. |
asfgit
pushed a commit
that referenced
this pull request
Sep 6, 2016
## What changes were proposed in this pull request? `DataSourceStrategy` does not consider `SQLConf` in `Context` and always match column names. For instance, `HiveContext` uses case insensitive configuration, but it's ignored in `DataSourceStrategy`. This issue was originally registered at SPARK-11301 against 1.6.0 and seemed to be fixed at that time, but Apache Spark 1.6.2 still handles **partitioned column name** in a case-sensitive way always. This is incorrect like the following. ```scala scala> sql("CREATE TABLE t(a int) PARTITIONED BY (b string) STORED AS PARQUET") scala> sql("INSERT INTO TABLE t PARTITION(b='P') SELECT * FROM (SELECT 1) t") scala> sql("INSERT INTO TABLE t PARTITION(b='Q') SELECT * FROM (SELECT 2) t") scala> sql("SELECT * FROM T WHERE B='P'").show +---+---+ | a| b| +---+---+ | 1| P| | 2| Q| +---+---+ ``` The result is the same with `set spark.sql.caseSensitive=false`. Here is the result in [Databricks CE](https://databricks-prod-cloudfront.cloud.databricks.com/public/4027ec902e239c93eaaa8714f173bcfc/6660119172909095/3421754458488607/5162191866050912/latest.html) . This PR reads the configuration and handle the column name comparison accordingly. ## How was this patch tested? Pass the Jenkins test with a modified test. Author: Dongjoon Hyun <dongjoon@apache.org> Closes #14970 from dongjoon-hyun/SPARK-11301.
|
thanks, merging to 1.6! |
|
Thank you, @cloud-fan ! |
|
can you close it? It's not merged to master and will not be closed automatically |
|
Sure! |
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
Sep 7, 2016
## What changes were proposed in this pull request?
`DataSourceStrategy` does not consider `SQLConf` in `Context` and always match column names. For instance, `HiveContext` uses case insensitive configuration, but it's ignored in `DataSourceStrategy`. This issue was originally registered at SPARK-11301 against 1.6.0 and seemed to be fixed at that time, but Apache Spark 1.6.2 still handles **partitioned column name** in a case-sensitive way always. This is incorrect like the following.
```scala
scala> sql("CREATE TABLE t(a int) PARTITIONED BY (b string) STORED AS PARQUET")
scala> sql("INSERT INTO TABLE t PARTITION(b='P') SELECT * FROM (SELECT 1) t")
scala> sql("INSERT INTO TABLE t PARTITION(b='Q') SELECT * FROM (SELECT 2) t")
scala> sql("SELECT * FROM T WHERE B='P'").show
+---+---+
| a| b|
+---+---+
| 1| P|
| 2| Q|
+---+---+
```
The result is the same with `set spark.sql.caseSensitive=false`. Here is the result in [Databricks CE](https://databricks-prod-cloudfront.cloud.databricks.com/public/4027ec902e239c93eaaa8714f173bcfc/6660119172909095/3421754458488607/5162191866050912/latest.html) .
This PR reads the configuration and handle the column name comparison accordingly.
## How was this patch tested?
Pass the Jenkins test with a modified test.
Author: Dongjoon Hyun <dongjoon@apache.org>
Closes apache#14970 from dongjoon-hyun/SPARK-11301.
(cherry picked from commit 958039a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
DataSourceStrategydoes not considerSQLConfinContextand always match column names. For instance,HiveContextuses case insensitive configuration, but it's ignored inDataSourceStrategy. This issue was originally registered at SPARK-11301 against 1.6.0 and seemed to be fixed at that time, but Apache Spark 1.6.2 still handles partitioned column name in a case-sensitive way always. This is incorrect like the following.The result is the same with
set spark.sql.caseSensitive=false. Here is the result in Databricks CE .This PR reads the configuration and handle the column name comparison accordingly.
How was this patch tested?
Pass the Jenkins test with a modified test.