Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-17339][CORE][BRANCH-2.0] Do not use path to get a filesystem in hadoopFile and newHadoopFile APIs #15008

Closed

Conversation

HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR backports #14960

How was this patch tested?

AppVeyor - https://ci.appveyor.com/project/HyukjinKwon/spark/build/86-backport-SPARK-17339-r

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Sep 8, 2016

Actually, I remember R tests were passed in #13165 with Windows in branch-2.0. So, I think this would not directly affect the R tests in 2.0;however, I thought it is safe not to use path to get a file system as discussed in #14960 (comment).

@HyukjinKwon
Copy link
Member Author

Could you take a look please? @sarutak

@HyukjinKwon HyukjinKwon changed the title [SPARK-17339][CORE][BRANCH-2.0] Do not use path to get a filesystem by using getLocal [SPARK-17339][CORE][BRANCH-2.0] Do not use path to get a filesystem in hadoopFile and newHadoopFile APIs Sep 8, 2016
@sarutak
Copy link
Member

sarutak commented Sep 8, 2016

LGTM. Pending Jenkins.

@SparkQA
Copy link

SparkQA commented Sep 8, 2016

Test build #65066 has finished for PR 15008 at commit 441431f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

shivaram commented Sep 8, 2016

Thanks - Merging this to branch-2.0

asfgit pushed a commit that referenced this pull request Sep 8, 2016
…n hadoopFile and newHadoopFile APIs

## What changes were proposed in this pull request?

This PR backports #14960

## How was this patch tested?

AppVeyor - https://ci.appveyor.com/project/HyukjinKwon/spark/build/86-backport-SPARK-17339-r

Author: hyukjinkwon <gurwls223@gmail.com>

Closes #15008 from HyukjinKwon/backport-SPARK-17339.
@shivaram
Copy link
Contributor

shivaram commented Sep 8, 2016

@HyukjinKwon I think you might need to manually close this PR

@HyukjinKwon
Copy link
Member Author

Yup, Thanks!

@HyukjinKwon HyukjinKwon closed this Sep 8, 2016
@HyukjinKwon HyukjinKwon deleted the backport-SPARK-17339 branch January 2, 2018 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants