Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-17389][Follow-up][ML] Change KMeans k-means|| default init steps from 5 to 2. #15050

Closed
wants to merge 1 commit into from

Conversation

yanboliang
Copy link
Contributor

What changes were proposed in this pull request?

#14956 reduced default k-means|| init steps to 2 from 5 only for spark.mllib package, we should also do same change for spark.ml and PySpark.

How was this patch tested?

Existing tests.

@yanboliang yanboliang changed the title [SPARK-17389][Follow-up][ML] Change KMeans k-means|| initialization steps from 5 to 2. [SPARK-17389][Follow-up][ML] Change KMeans k-means|| default init steps from 5 to 2. Sep 11, 2016
@yanboliang
Copy link
Contributor Author

cc @srowen

@srowen
Copy link
Member

srowen commented Sep 11, 2016

Oh, whoops, completely missed that there are also defaults specified in the wrapper classes. Thank you

@SparkQA
Copy link

SparkQA commented Sep 11, 2016

Test build #65223 has finished for PR 15050 at commit bd71eb6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Sep 11, 2016

Also merged to master

@asfgit asfgit closed this in 883c763 Sep 11, 2016
@yanboliang yanboliang deleted the spark-17389 branch September 11, 2016 13:00
wgtmac pushed a commit to wgtmac/spark that referenced this pull request Sep 19, 2016
…ps from 5 to 2.

## What changes were proposed in this pull request?
apache#14956 reduced default k-means|| init steps to 2 from 5 only for spark.mllib package, we should also do same change for spark.ml and PySpark.

## How was this patch tested?
Existing tests.

Author: Yanbo Liang <ybliang8@gmail.com>

Closes apache#15050 from yanboliang/spark-17389.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants