Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-17239][ML][DOC] Update user guide for multiclass logistic regression #15349

Closed
wants to merge 2 commits into from

Conversation

sethah
Copy link
Contributor

@sethah sethah commented Oct 4, 2016

What changes were proposed in this pull request?

Updates user guide to reflect that LogisticRegression now supports multiclass. Also adds new examples to show multiclass training.

How was this patch tested?

Ran locally using spark-submit, run-example, and copy/paste from user guide into shells. Generated docs and verified correct output.

@sethah
Copy link
Contributor Author

sethah commented Oct 4, 2016

@@ -45,6 +45,19 @@ object LogisticRegressionWithElasticNetExample {

// Print the coefficients and intercept for logistic regression
println(s"Coefficients: ${lrModel.coefficients} Intercept: ${lrModel.intercept}")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modified the existing examples to show that multinomial can be used with binary classification. It might be too confusing, but then that might be more reason to have some example to clarify it. I appreciate feedback here.

@SparkQA
Copy link

SparkQA commented Oct 4, 2016

Test build #66332 has finished for PR 15349 at commit 0144aff.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dbtsai
Copy link
Member

dbtsai commented Oct 5, 2016

LGTM. Merged into master. Thanks.

@asfgit asfgit closed this in 9df54f5 Oct 5, 2016
@sethah
Copy link
Contributor Author

sethah commented Oct 5, 2016

Thanks @dbtsai!

uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
…ession

## What changes were proposed in this pull request?
Updates user guide to reflect that LogisticRegression now supports multiclass. Also adds new examples to show multiclass training.

## How was this patch tested?
Ran locally using spark-submit, run-example, and copy/paste from user guide into shells. Generated docs and verified correct output.

Author: sethah <seth.hendrickson16@gmail.com>

Closes apache#15349 from sethah/SPARK-17239.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants