Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-2683] unidoc failed because org.apache.spark.util.CallSite uses Java keywords as value names #1585

Closed
wants to merge 1 commit into from
Closed

[SPARK-2683] unidoc failed because org.apache.spark.util.CallSite uses Java keywords as value names #1585

wants to merge 1 commit into from

Conversation

yhuai
Copy link
Contributor

@yhuai yhuai commented Jul 25, 2014

Renaming short to shortForm and long to longForm.

JIRA: https://issues.apache.org/jira/browse/SPARK-2683

@yhuai yhuai mentioned this pull request Jul 25, 2014
Closed
@yhuai
Copy link
Contributor Author

yhuai commented Jul 25, 2014

test this please

@SparkQA
Copy link

SparkQA commented Jul 25, 2014

QA tests have started for PR 1585. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17185/consoleFull

@SparkQA
Copy link

SparkQA commented Jul 25, 2014

QA results for PR 1585:
- This patch FAILED unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17185/consoleFull

@yhuai
"short" and "long" are Java keyworks. In order to generate javadoc, r…
5ddb843 
…enaming "short" to "shortForm" and "long" to "longForm".
@SparkQA
Copy link

SparkQA commented Jul 25, 2014

QA tests have started for PR 1585. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17187/consoleFull

@SparkQA
Copy link

SparkQA commented Jul 25, 2014

QA results for PR 1585:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17187/consoleFull

@mateiz
Copy link
Contributor

mateiz commented Jul 25, 2014

Good catch.. maybe we need to make unidoc part of our test process. Can you open a JIRA for that? (Unfortunately I'm not sure how long it would take, it might increase our build time by another 5 or so minutes.)

@yhuai
Copy link
Contributor Author

yhuai commented Jul 25, 2014

Sure. I have created https://issues.apache.org/jira/browse/SPARK-2690 to track it.

@asfgit asfgit closed this in 32bcf9a Jul 25, 2014
asfgit pushed a commit that referenced this pull request Jul 25, 2014
@yhuai @mateiz
[SPARK-2682] Javadoc generated from Scala source code is not in javad…
a19d8c8 
…oc's index

Add genjavadocSettings back to SparkBuild. It requires #1585 .

https://issues.apache.org/jira/browse/SPARK-2682

Author: Yin Huai <huai@cse.ohio-state.edu>

Closes #1584 from yhuai/SPARK-2682 and squashes the following commits:

2e89461 [Yin Huai] Merge remote-tracking branch 'upstream/master' into SPARK-2682
54e3b66 [Yin Huai] Add genjavadocSettings back.
@yhuai yhuai deleted the SPARK-2683 branch July 31, 2014 21:10
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@yhuai @conviva-zz
[SPARK-2683] unidoc failed because org.apache.spark.util.CallSite use…
db2d598 
…s Java keywords as value names

Renaming `short` to `shortForm` and `long` to `longForm`.

JIRA: https://issues.apache.org/jira/browse/SPARK-2683

Author: Yin Huai <huai@cse.ohio-state.edu>

Closes apache#1585 from yhuai/SPARK-2683 and squashes the following commits:

5ddb843 [Yin Huai] "short" and "long" are Java keyworks. In order to generate javadoc, renaming "short" to "shortForm" and "long" to "longForm".
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@yhuai @conviva-zz
[SPARK-2682] Javadoc generated from Scala source code is not in javad…
fe13f70 
…oc's index

Add genjavadocSettings back to SparkBuild. It requires apache#1585 .

https://issues.apache.org/jira/browse/SPARK-2682

Author: Yin Huai <huai@cse.ohio-state.edu>

Closes apache#1584 from yhuai/SPARK-2682 and squashes the following commits:

2e89461 [Yin Huai] Merge remote-tracking branch 'upstream/master' into SPARK-2682
54e3b66 [Yin Huai] Add genjavadocSettings back.
sunchao pushed a commit to sunchao/spark that referenced this pull request Jun 2, 2023
@viirya
rdar://100784942: Add additional checkpoint rename file check (apache…
9a038f8 
…#1585)

Customer structured streaming job failed to read delta file which makes re-triggering the job impossible. This adds an additional checkpoint renamed file check to guard it in advance.

This is guarded by a SQL config too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@yhuai @SparkQA @mateiz