[SPARK-18507][SQL] HiveExternalCatalog.listPartitions should only call getTable once #15978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #68993 has finished for PR 15978 at commit
|
|
I'll give this patch a try. Thanks. |
|
This patch resolves the performance problem I was seeing. Thank you! |
|
Lgtm. Should we also add a metric on the number if hive calls and check that in the table perf stats suite to prevent future regression? |
|
Oops, that was my fault. Thanks merging into master 2.1 |
asfgit
pushed a commit
that referenced
this pull request
Nov 22, 2016
…l getTable once ## What changes were proposed in this pull request? HiveExternalCatalog.listPartitions should only call `getTable` once, instead of calling it for every partitions. ## How was this patch tested? N/A Author: Wenchen Fan <wenchen@databricks.com> Closes #15978 from cloud-fan/perf. (cherry picked from commit 702cd40) Signed-off-by: Andrew Or <andrewor14@gmail.com>
|
@cloud-fan can you make a patch for 2.0? |
|
(Actually never mind, not my fault! :p) |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 2, 2016
…l getTable once ## What changes were proposed in this pull request? HiveExternalCatalog.listPartitions should only call `getTable` once, instead of calling it for every partitions. ## How was this patch tested? N/A Author: Wenchen Fan <wenchen@databricks.com> Closes apache#15978 from cloud-fan/perf.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…l getTable once ## What changes were proposed in this pull request? HiveExternalCatalog.listPartitions should only call `getTable` once, instead of calling it for every partitions. ## How was this patch tested? N/A Author: Wenchen Fan <wenchen@databricks.com> Closes apache#15978 from cloud-fan/perf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HiveExternalCatalog.listPartitions should only call
getTableonce, instead of calling it for every partitions.How was this patch tested?
N/A