[SPARK-18482][SQL] make sure Spark can access the table metadata created by older version of spark #16003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
commented
Nov 24, 2016
| @@ -1370,47 +1370,4 @@ class MetastoreDataSourcesSuite extends QueryTest with SQLTestUtils with TestHiv | |||
| sparkSession.sparkContext.conf.set(DEBUG_MODE, previousValue) | |||
| } | |||
| } | |||
|
|
|||
| test("SPARK-17470: support old table that stores table location in storage properties") { | |||
cloud-fan
commented
Nov 24, 2016
| } | ||
| } | ||
|
|
||
| test("SPARK-18464: support old table which doesn't store schema in table properties") { |
There was a problem hiding this comment.
it's covered by the new test suite
|
Test build #69134 has finished for PR 16003 at commit
|
rxin
reviewed
Nov 24, 2016
| import org.apache.spark.util.Utils | ||
|
|
||
|
|
||
| class HiveExternalCatalogCompatibilitySuite extends QueryTest with TestHiveSingleton { |
There was a problem hiding this comment.
To make the name super long...
HiveExternalCatalogBackwardCompatibilitySuite
|
Test build #69145 has finished for PR 16003 at commit
|
|
The main thing I'd add is to add comment explaining what version of Spark would generate those table props. |
|
How about Spark 2.1 altering the table metadata created by Spark 2.0? |
|
Test build #69200 has started for PR 16003 at commit |
|
Test build #3440 has finished for PR 16003 at commit
|
gatorsmile
reviewed
Nov 27, 2016
|
|
||
|
|
||
| // Raw table metadata that are dumped from tables created by Spark 2.0. Note that, all spark | ||
| // versions prior to 2.1 would generate same raw table metadata for a specific table. |
There was a problem hiding this comment.
I briefly checked 1.6. Most of them are the same, but some changes are only available in 2.0. For example, locationUri = Some(defaultTablePath("tbl7") + "-__PLACEHOLDER__"), was added in #13270
|
LGTM except a minor comment. We can address it in a separate PR for checking 1.6. |
|
Test build #69217 has finished for PR 16003 at commit
|
|
Merging in master/branch-2.1. |
asfgit
pushed a commit
that referenced
this pull request
Nov 28, 2016
…ted by older version of spark ## What changes were proposed in this pull request? In Spark 2.1, we did a lot of refactor for `HiveExternalCatalog` and related code path. These refactor may introduce external behavior changes and break backward compatibility. e.g. http://issues.apache.org/jira/browse/SPARK-18464 To avoid future compatibility problems of `HiveExternalCatalog`, this PR dumps some typical table metadata from tables created by 2.0, and test if they can recognized by current version of Spark. ## How was this patch tested? test only change Author: Wenchen Fan <wenchen@databricks.com> Closes #16003 from cloud-fan/test. (cherry picked from commit fc2c13b) Signed-off-by: Reynold Xin <rxin@databricks.com>
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 2, 2016
…ted by older version of spark ## What changes were proposed in this pull request? In Spark 2.1, we did a lot of refactor for `HiveExternalCatalog` and related code path. These refactor may introduce external behavior changes and break backward compatibility. e.g. http://issues.apache.org/jira/browse/SPARK-18464 To avoid future compatibility problems of `HiveExternalCatalog`, this PR dumps some typical table metadata from tables created by 2.0, and test if they can recognized by current version of Spark. ## How was this patch tested? test only change Author: Wenchen Fan <wenchen@databricks.com> Closes apache#16003 from cloud-fan/test.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…ted by older version of spark ## What changes were proposed in this pull request? In Spark 2.1, we did a lot of refactor for `HiveExternalCatalog` and related code path. These refactor may introduce external behavior changes and break backward compatibility. e.g. http://issues.apache.org/jira/browse/SPARK-18464 To avoid future compatibility problems of `HiveExternalCatalog`, this PR dumps some typical table metadata from tables created by 2.0, and test if they can recognized by current version of Spark. ## How was this patch tested? test only change Author: Wenchen Fan <wenchen@databricks.com> Closes apache#16003 from cloud-fan/test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In Spark 2.1, we did a lot of refactor for
HiveExternalCatalogand related code path. These refactor may introduce external behavior changes and break backward compatibility. e.g. http://issues.apache.org/jira/browse/SPARK-18464To avoid future compatibility problems of
HiveExternalCatalog, this PR dumps some typical table metadata from tables created by 2.0, and test if they can recognized by current version of Spark.How was this patch tested?
test only change