Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-2742][yarn] delete useless variables #1614

Closed
wants to merge 1 commit into from
Closed

[SPARK-2742][yarn] delete useless variables #1614

wants to merge 1 commit into from

Conversation

XuTingjun
Copy link
Contributor

No description provided.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@mateiz
Copy link
Contributor

mateiz commented Jul 28, 2014

Jenkins, this is ok to test

@SparkQA
Copy link

SparkQA commented Jul 28, 2014

QA tests have started for PR 1614. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17272/consoleFull

@SparkQA
Copy link

SparkQA commented Jul 28, 2014

QA results for PR 1614:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17272/consoleFull

@mateiz
Copy link
Contributor

mateiz commented Jul 29, 2014

@XuTingjun mind creating a JIRA issue on https://issues.apache.org/jira/browse/SPARK so we can track this? When you do, update the pull request's title with the JIRA number.

@XuTingjun XuTingjun changed the title [yarn] delete useless variables [SPARK-2742][yarn] delete useless variables Jul 30, 2014
@XuTingjun
Copy link
Contributor Author

Patrick Wendell has closed this JIRA issue.

@tgravescs
Copy link
Contributor

changes look fine to me.

@XuTingjun
Copy link
Contributor Author

How should I deal with it ? Should I close it ?

@tgravescs
Copy link
Contributor

no. The jira was accidentally closed. We should still pull this in.

@tgravescs
Copy link
Contributor

I merged this into master branch.

@asfgit asfgit closed this in 220c2d7 Aug 22, 2014
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@XuTingjun @conviva-zz
[SPARK-2742][yarn] delete useless variables
e69ac65 
Author: XuTingjun <1039320815@qq.com>

Closes apache#1614 from XuTingjun/yarn-bug and squashes the following commits:

f07096e [XuTingjun] Update ClientArguments.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@XuTingjun @AmplabJenkins @mateiz @SparkQA @tgravescs