[SPARK-18711][SQL] should disable subexpression elimination for LambdaVariable #16143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #69665 has finished for PR 16143 at commit
|
|
LGTM - merging to master/2.1. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Dec 5, 2016
…aVariable ## What changes were proposed in this pull request? This is kind of a long-standing bug, it's hidden until #15780 , which may add `AssertNotNull` on top of `LambdaVariable` and thus enables subexpression elimination. However, subexpression elimination will evaluate the common expressions at the beginning, which is invalid for `LambdaVariable`. `LambdaVariable` usually represents loop variable, which can't be evaluated ahead of the loop. This PR skips expressions containing `LambdaVariable` when doing subexpression elimination. ## How was this patch tested? updated test in `DatasetAggregatorSuite` Author: Wenchen Fan <wenchen@databricks.com> Closes #16143 from cloud-fan/aggregator. (cherry picked from commit 01a7d33) Signed-off-by: Herman van Hovell <hvanhovell@databricks.com>
|
thanks for getting this fixed so fast |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 15, 2016
…aVariable ## What changes were proposed in this pull request? This is kind of a long-standing bug, it's hidden until apache#15780 , which may add `AssertNotNull` on top of `LambdaVariable` and thus enables subexpression elimination. However, subexpression elimination will evaluate the common expressions at the beginning, which is invalid for `LambdaVariable`. `LambdaVariable` usually represents loop variable, which can't be evaluated ahead of the loop. This PR skips expressions containing `LambdaVariable` when doing subexpression elimination. ## How was this patch tested? updated test in `DatasetAggregatorSuite` Author: Wenchen Fan <wenchen@databricks.com> Closes apache#16143 from cloud-fan/aggregator.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…aVariable ## What changes were proposed in this pull request? This is kind of a long-standing bug, it's hidden until apache#15780 , which may add `AssertNotNull` on top of `LambdaVariable` and thus enables subexpression elimination. However, subexpression elimination will evaluate the common expressions at the beginning, which is invalid for `LambdaVariable`. `LambdaVariable` usually represents loop variable, which can't be evaluated ahead of the loop. This PR skips expressions containing `LambdaVariable` when doing subexpression elimination. ## How was this patch tested? updated test in `DatasetAggregatorSuite` Author: Wenchen Fan <wenchen@databricks.com> Closes apache#16143 from cloud-fan/aggregator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is kind of a long-standing bug, it's hidden until #15780 , which may add
AssertNotNullon top ofLambdaVariableand thus enables subexpression elimination.However, subexpression elimination will evaluate the common expressions at the beginning, which is invalid for
LambdaVariable.LambdaVariableusually represents loop variable, which can't be evaluated ahead of the loop.This PR skips expressions containing
LambdaVariablewhen doing subexpression elimination.How was this patch tested?
updated test in
DatasetAggregatorSuite