Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-18744][Core]Remove workaround for Netty memory leak #16167

Closed
wants to merge 1 commit into from
Closed

[SPARK-18744][Core]Remove workaround for Netty memory leak #16167

wants to merge 1 commit into from

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Dec 6, 2016

What changes were proposed in this pull request?

We added some codes in #14961 because of netty/netty#5833

Now we can remove them as it's fixed in Netty 4.0.42.Final.

How was this patch tested?

Jenkins

@SparkQA
Copy link

SparkQA commented Dec 6, 2016

Test build #69711 has finished for PR 16167 at commit 41066dd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing zsxwing changed the title [DO NOT MERGE]Remove workaround for Netty memory leak [SPARK-18744][Core]Remove workaround for Netty memory leak Dec 6, 2016
@zsxwing
Copy link
Member Author

zsxwing commented Dec 6, 2016

cc @srowen

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for master

@zsxwing
Copy link
Member Author

zsxwing commented Dec 6, 2016

Thanks! Merging to master.

@asfgit asfgit closed this in eeed38e Dec 6, 2016
@zsxwing zsxwing deleted the remove-netty-workaround branch December 6, 2016 21:37
robert3005 pushed a commit to palantir/spark that referenced this pull request Dec 15, 2016
## What changes were proposed in this pull request?

We added some codes in apache#14961 because of netty/netty#5833

Now we can remove them as it's fixed in Netty 4.0.42.Final.

## How was this patch tested?

Jenkins

Author: Shixiong Zhu <shixiong@databricks.com>

Closes apache#16167 from zsxwing/remove-netty-workaround.
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
## What changes were proposed in this pull request?

We added some codes in apache#14961 because of netty/netty#5833

Now we can remove them as it's fixed in Netty 4.0.42.Final.

## How was this patch tested?

Jenkins

Author: Shixiong Zhu <shixiong@databricks.com>

Closes apache#16167 from zsxwing/remove-netty-workaround.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants