Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-2714] DAGScheduler logs jobid when runJob finishes #1617

Closed
wants to merge 5 commits into from

Conversation

YanTangZhai
Copy link
Contributor

DAGScheduler logs jobid when runJob finishes

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@markhamstra
Copy link
Contributor

What is the need to expose the jobId after the job is finished?

@YanTangZhai
Copy link
Contributor Author

Hi @markhamstra When DAGScheduler concurrently runs multiple jobs, SparkContext only logs "Job finished" and logs in the same file which doesn't tell who is who. It's difficult to found which job has finished or how much time it has taken from multiple "Job finished: ..., took ... s" logs.

@andrewor14
Copy link
Contributor

ok to test

logInfo(
"Job " + waiter.jobId + " finished: " + callSite.shortForm +
", took " + (System.nanoTime - start) / 1e9 + " s")
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do string formatting instead to make this more readable:

logInfo("Job %d finished: %s, took %ds".format(
  (waiter.jobId, callSite.shortForm, (System.nanoTime - start) / 1e9))

@SparkQA
Copy link

SparkQA commented Sep 11, 2014

QA tests have started for PR 1617 at commit fb42f0f.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 12, 2014

QA tests have finished for PR 1617 at commit fb42f0f.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 12, 2014

QA tests have started for PR 1617 at commit 7aec2a9.

  • This patch merges cleanly.

@YanTangZhai
Copy link
Contributor Author

@andrewor14 Thanks. Please review again.

@SparkQA
Copy link

SparkQA commented Sep 12, 2014

QA tests have started for PR 1617 at commit fbb1150.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 12, 2014

Tests timed out after a configured wait of 120m.

@SparkQA
Copy link

SparkQA commented Sep 12, 2014

Tests timed out after a configured wait of 120m.

case JobFailed(exception: Exception) =>
logInfo("Failed to run " + callSite.shortForm)
logInfo("Job %d failed: %s, took %d s".format
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, the last one has to be %f, here and in L431

@SparkQA
Copy link

SparkQA commented Sep 15, 2014

QA tests have started for PR 1617 at commit 0a0243f.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 15, 2014

QA tests have finished for PR 1617 at commit 0a0243f.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

Thanks, merging this into master.

@asfgit asfgit closed this in 37d9252 Sep 15, 2014
sunchao pushed a commit to sunchao/spark that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants