Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-18900][FLAKY-TEST] StateStoreSuite.maintenance #16314

Closed
wants to merge 1 commit into from

Conversation

brkyvz
Copy link
Contributor

@brkyvz brkyvz commented Dec 16, 2016

What changes were proposed in this pull request?

It was pretty flaky before 10 days ago.
https://spark-tests.appspot.com/test-details?suite_name=org.apache.spark.sql.execution.streaming.state.StateStoreSuite&test_name=maintenance

Since no code changes went into this code path to not be so flaky, I'm just increasing the timeouts such that load related flakiness shouldn't be a problem. As you may see from the testing, I haven't been able to reproduce it.

How was this patch tested?

2000 retries 5 times

@brkyvz brkyvz changed the title [FALKY-TEST][DO-NOT-MERGE] StateStoreSuite.maintenance [SPARK-18900][FLAKY-TEST][DO-NOT-MERGE] StateStoreSuite.maintenance Dec 16, 2016
@brkyvz
Copy link
Contributor Author

brkyvz commented Dec 16, 2016

retest this please

@SparkQA
Copy link

SparkQA commented Dec 16, 2016

Test build #70270 has finished for PR 16314 at commit 1440de2.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@brkyvz
Copy link
Contributor Author

brkyvz commented Dec 16, 2016

retest this please

@SparkQA
Copy link

SparkQA commented Dec 16, 2016

Test build #70272 has finished for PR 16314 at commit 1440de2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 16, 2016

Test build #70273 has finished for PR 16314 at commit 1440de2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 16, 2016

Test build #70263 has finished for PR 16314 at commit ccb7f95.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 16, 2016

Test build #70278 has finished for PR 16314 at commit ae36d90.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 16, 2016

Test build #70265 has finished for PR 16314 at commit 1440de2.

  • This patch fails from timeout after a configured wait of `250m`.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 17, 2016

Test build #70312 has finished for PR 16314 at commit abff69c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@brkyvz
Copy link
Contributor Author

brkyvz commented Dec 19, 2016

retest this please

@SparkQA
Copy link

SparkQA commented Dec 19, 2016

Test build #70367 has finished for PR 16314 at commit abff69c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@brkyvz brkyvz changed the title [SPARK-18900][FLAKY-TEST][DO-NOT-MERGE] StateStoreSuite.maintenance [SPARK-18900][FLAKY-TEST] StateStoreSuite.maintenance Dec 19, 2016
@SparkQA
Copy link

SparkQA commented Dec 20, 2016

Test build #70384 has finished for PR 16314 at commit 6775639.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@tdas
Copy link
Contributor

tdas commented Dec 21, 2016

Merging this master and 2.1

asfgit pushed a commit that referenced this pull request Dec 21, 2016
## What changes were proposed in this pull request?

It was pretty flaky before 10 days ago.
https://spark-tests.appspot.com/test-details?suite_name=org.apache.spark.sql.execution.streaming.state.StateStoreSuite&test_name=maintenance

Since no code changes went into this code path to not be so flaky, I'm just increasing the timeouts such that load related flakiness shouldn't be a problem. As you may see from the testing, I haven't been able to reproduce it.

## How was this patch tested?

2000 retries 5 times

Author: Burak Yavuz <brkyvz@gmail.com>

Closes #16314 from brkyvz/maint-flaky.

(cherry picked from commit b2dd8ec)
Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
@asfgit asfgit closed this in b2dd8ec Dec 21, 2016
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
## What changes were proposed in this pull request?

It was pretty flaky before 10 days ago.
https://spark-tests.appspot.com/test-details?suite_name=org.apache.spark.sql.execution.streaming.state.StateStoreSuite&test_name=maintenance

Since no code changes went into this code path to not be so flaky, I'm just increasing the timeouts such that load related flakiness shouldn't be a problem. As you may see from the testing, I haven't been able to reproduce it.

## How was this patch tested?

2000 retries 5 times

Author: Burak Yavuz <brkyvz@gmail.com>

Closes apache#16314 from brkyvz/maint-flaky.
@brkyvz brkyvz deleted the maint-flaky branch February 3, 2019 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants