Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-18920][HISTORYSERVER]Update outdated date formatting #16331

Closed
wants to merge 1 commit into from

Conversation

WangTaoTheTonic
Copy link
Contributor

What changes were proposed in this pull request?

Before we show "-" while the timestamp is less than 0, we should update it as now the date string is presented in format "yyyy-MM-dd ....."

How was this patch tested?

Before:
historyserver-before

After:
history-after

@SparkQA
Copy link

SparkQA commented Dec 19, 2016

Test build #70326 has finished for PR 16331 at commit 1618d1d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Dec 19, 2016

I don't think this can be the right change -- it's construing any date before 2000 as invalid, which may happen to be OK but is pretty arbitrary. It arises as the result of formatting -1 as a date, and this method seems to try to handle that, but it's comparing the string to -1 I guess. Surely this should be handled elsewhere, like in whatever calls formatDate?

@srowen
Copy link
Member

srowen commented Dec 23, 2016

Ping @WangTaoTheTonic I don't think we can make this change -- can you investigate a more fundamental fix or close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants