[SPARK-18963] o.a.s.unsafe.types.UTF8StringSuite.writeToOutputStreamIntArray test #16375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fails on big endian. Only change byte order on little endian
robbinspg
changed the title
|
Test build #70475 has finished for PR 16375 at commit
|
srowen
reviewed
Dec 21, 2016
| @@ -591,7 +591,11 @@ public void writeToOutputStreamIntArray() throws IOException { | |||
| // verify that writes work on objects that are not byte arrays | |||
| final ByteBuffer buffer = StandardCharsets.UTF_8.encode("大千世界"); | |||
| buffer.position(0); | |||
| buffer.order(ByteOrder.LITTLE_ENDIAN); | |||
|
|
|||
There was a problem hiding this comment.
Can this just be buffer.order(ByteOrder.nativeOrder())? that's what's done elsewhere.
CC @NathanHowell for a thought.
There was a problem hiding this comment.
Yeah, that's probably the right approach.
There was a problem hiding this comment.
Ok I'll change it to that
srowen
approved these changes
Dec 22, 2016
|
Test build #70514 has finished for PR 16375 at commit
|
|
Jenkins retest this please |
|
Test build #70515 has finished for PR 16375 at commit
|
|
Test run is failing with an unrelated error |
|
Test build #3513 has finished for PR 16375 at commit
|
|
Test build #70546 has finished for PR 16375 at commit
|
|
Merged to master |
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Dec 24, 2016
…ntArray test fails on big endian. Only change byte order on little endian ## What changes were proposed in this pull request? Fix test to only change byte order on LE platforms ## How was this patch tested? Test run on Big Endian and Little Endian platforms Author: Pete Robbins <robbinspg@gmail.com> Closes apache#16375 from robbinspg/SPARK-18963.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…ntArray test fails on big endian. Only change byte order on little endian ## What changes were proposed in this pull request? Fix test to only change byte order on LE platforms ## How was this patch tested? Test run on Big Endian and Little Endian platforms Author: Pete Robbins <robbinspg@gmail.com> Closes apache#16375 from robbinspg/SPARK-18963.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fails on big endian. Only change byte order on little endian
What changes were proposed in this pull request?
Fix test to only change byte order on LE platforms
How was this patch tested?
Test run on Big Endian and Little Endian platforms