[SPARK-19026]SPARK_LOCAL_DIRS(multiple directories on different disks) cannot be deleted #16439
Conversation
…or-*** throws IOException
| Some(appDir.getAbsolutePath()) | ||
| } catch { | ||
| case e: IOException => | ||
| logError(s"${e.getMessage}. Ignoring this directory.") |
There was a problem hiding this comment.
Thanks for your review, i will merge it.
| None | ||
| } | ||
| }.toSeq | ||
| if (dirs.length <= 0) { |
|
@srowen i do not think there should be a fatal error since some of SPARK_LOCAL_DIRS can be written successfully, even there is only one of SPARK_LOCAL_DIRS can be written, the application is able to run successfully. |
|
Would it be common to configure some directories for use but not mind if they're unwritable? It seems like this is an explicit setting and if the explicit setting can't be honored, feels like an error to me. What's the use case? |
I guess you wouldn't configure an unwritable directory, but it can become unwritable for other reasons (e.g. disk fills up). |
|
Test build #3521 has finished for PR 16439 at commit
|
| } | ||
| }.toSeq | ||
| if (dirs.isEmpty) { | ||
| throw new IOException("None subfolder can be created in " + |
There was a problem hiding this comment.
Thanks vanzin. i will commit it.
| }.toSeq | ||
| if (dirs.isEmpty) { | ||
| throw new IOException("None subfolder can be created in " + | ||
| s"${Utils.getOrCreateLocalRootDirs(conf).mkString(",")}.") |
There was a problem hiding this comment.
I'd stash Utils.getOrCreateLocalRootDirs(conf) in a variable since it's also used above in L449.
There was a problem hiding this comment.
Thanks vanzin. i will commit it
|
retest this please |
|
Test build #70993 has finished for PR 16439 at commit
|
|
Merged to master |
…s) cannot be deleted JIRA Issue: https://issues.apache.org/jira/browse/SPARK-19026 SPARK_LOCAL_DIRS (Standalone) can be a comma-separated list of multiple directories on different disks, e.g. SPARK_LOCAL_DIRS=/dir1,/dir2,/dir3, if there is a IOExecption when create sub directory on dir3 , the sub directory which have been created successfully on dir1 and dir2 cannot be deleted anymore when the application finishes. So we should catch the IOExecption at Utils.createDirectory , otherwise the variable "appDirectories(appId)" which the function maybeCleanupApplication calls will not be set then dir1 and dir2 will not be cleaned up . Author: zuotingbing <zuo.tingbing9@zte.com.cn> Closes apache#16439 from zuotingbing/master.
…s) cannot be deleted JIRA Issue: https://issues.apache.org/jira/browse/SPARK-19026 SPARK_LOCAL_DIRS (Standalone) can be a comma-separated list of multiple directories on different disks, e.g. SPARK_LOCAL_DIRS=/dir1,/dir2,/dir3, if there is a IOExecption when create sub directory on dir3 , the sub directory which have been created successfully on dir1 and dir2 cannot be deleted anymore when the application finishes. So we should catch the IOExecption at Utils.createDirectory , otherwise the variable "appDirectories(appId)" which the function maybeCleanupApplication calls will not be set then dir1 and dir2 will not be cleaned up . Author: zuotingbing <zuo.tingbing9@zte.com.cn> Closes apache#16439 from zuotingbing/master.
JIRA Issue: https://issues.apache.org/jira/browse/SPARK-19026
SPARK_LOCAL_DIRS (Standalone) can be a comma-separated list of multiple directories on different disks, e.g. SPARK_LOCAL_DIRS=/dir1,/dir2,/dir3, if there is a IOExecption when create sub directory on dir3 , the sub directory which have been created successfully on dir1 and dir2 cannot be deleted anymore when the application finishes.
So we should catch the IOExecption at Utils.createDirectory , otherwise the variable "appDirectories(appId)" which the function maybeCleanupApplication calls will not be set then dir1 and dir2 will not be cleaned up .