delete useless var “j” #16676
Closed
delete useless var “j” #16676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the var “j” defined in "var j = 0" is useless for “def compress”
|
@xiaoyesoso we usually do not merge changes this trivial, that have no real impact on the code. I agree it can be removed. It would be helpful if you can look for other unused variables -- IDEs like IntelliJ can do this. We could try to fix many of these at once. If it's your first contribution we often will merge something like this anyway but not regularly. |
|
@srowen Yes, it's my first contribution.Thank you. |
|
ok to test |
|
Test build #71927 has finished for PR 16676 at commit
|
|
Merged to master. Please read http://spark.apache.org/contributing.html for next time. |
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
the var “j” defined in "var j = 0" is useless for “def compress” Author: Souljoy Zhuo <zhuoshoujie@126.com> Closes apache#16676 from xiaoyesoso/patch-1.
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 15, 2017
the var “j” defined in "var j = 0" is useless for “def compress” Author: Souljoy Zhuo <zhuoshoujie@126.com> Closes apache#16676 from xiaoyesoso/patch-1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the var “j” defined in "var j = 0" is useless for “def compress”