[SPARK-19272][SQL] Remove the param viewOriginalText from CatalogTable
#16679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan |
cloud-fan
reviewed
Jan 23, 2017
| @@ -528,8 +528,10 @@ case class DescribeTableCommand( | |||
| private def describeViewInfo(metadata: CatalogTable, buffer: ArrayBuffer[Row]): Unit = { | |||
| append(buffer, "", "", "") | |||
| append(buffer, "# View Information", "", "") | |||
| append(buffer, "View Original Text:", metadata.viewOriginalText.getOrElse(""), "") | |||
| append(buffer, "View Expanded Text:", metadata.viewText.getOrElse(""), "") | |||
|
Test build #71835 has finished for PR 16679 at commit
|
gatorsmile
reviewed
Jan 23, 2017
| @@ -426,7 +426,6 @@ private[hive] class HiveClientImpl( | |||
| // in the function toHiveTable. | |||
| properties = properties.filter(kv => kv._1 != "comment" && kv._1 != "EXTERNAL"), | |||
| comment = properties.get("comment"), | |||
| viewOriginalText = Option(h.getViewOriginalText), | |||
| viewText = Option(h.getViewExpandedText), | |||
There was a problem hiding this comment.
Could you add a comment in this line to explain why we are using h.getViewExpandedText instead of h.getViewOriginalText?
|
Test build #71868 has finished for PR 16679 at commit
|
gatorsmile
reviewed
Jan 24, 2017
| viewOriginalText = Option(h.getViewOriginalText), | ||
| // In older versions of Spark(before 2.2.0), we expand the view original text and store | ||
| // that into `viewExpandedText`, and that should be used in view resolution. So we get | ||
| // `viewExpandedText` instead of `viewOriginalText` for viewText here. |
There was a problem hiding this comment.
BTW, do we have a test case to cover the backward compatibility? That means, Spark 2.2.0 still can use/call the view created by Spark 2.1.0?
There was a problem hiding this comment.
IIRC, we do have such a test
|
Test build #71900 has finished for PR 16679 at commit
|
|
thanks, merging to master! |
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…able` ## What changes were proposed in this pull request? Hive will expand the view text, so it needs 2 fields: originalText and viewText. Since we don't expand the view text, but only add table properties, perhaps only a single field `viewText` is enough in CatalogTable. This PR brought in the following changes: 1. Remove the param `viewOriginalText` from `CatalogTable`; 2. Update the output of command `DescribeTableCommand`. ## How was this patch tested? Tested by exsiting test cases, also updated the failed test cases. Author: jiangxingbo <jiangxb1987@gmail.com> Closes apache#16679 from jiangxb1987/catalogTable.
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 15, 2017
…able` ## What changes were proposed in this pull request? Hive will expand the view text, so it needs 2 fields: originalText and viewText. Since we don't expand the view text, but only add table properties, perhaps only a single field `viewText` is enough in CatalogTable. This PR brought in the following changes: 1. Remove the param `viewOriginalText` from `CatalogTable`; 2. Update the output of command `DescribeTableCommand`. ## How was this patch tested? Tested by exsiting test cases, also updated the failed test cases. Author: jiangxingbo <jiangxb1987@gmail.com> Closes apache#16679 from jiangxb1987/catalogTable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Hive will expand the view text, so it needs 2 fields: originalText and viewText. Since we don't expand the view text, but only add table properties, perhaps only a single field
viewTextis enough in CatalogTable.This PR brought in the following changes:
viewOriginalTextfromCatalogTable;DescribeTableCommand.How was this patch tested?
Tested by exsiting test cases, also updated the failed test cases.