Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-2523] [SQL] Hadoop table scan bug fixing (fix failing Jenkins maven test) #1669

Closed
wants to merge 1 commit into from
Closed

[SPARK-2523] [SQL] Hadoop table scan bug fixing (fix failing Jenkins maven test) #1669

wants to merge 1 commit into from

Conversation

yhuai
Copy link
Contributor

@yhuai yhuai commented Jul 30, 2014

This PR tries to resolve the broken Jenkins maven test issue introduced by #1439. Now, we create a single query test to run both the setup work and the test query.

@marmbrus
Copy link
Contributor

Oh, clever. This isn't actually what I was suggesting but is a better solution :) I forgot that createQueryTest could handle multiple sql statements.

@yhuai
Copy link
Contributor Author

yhuai commented Jul 30, 2014

test this please

1 similar comment
@marmbrus
Copy link
Contributor

test this please

@chenghao-intel
Copy link
Contributor

Thank you @yhuai, that seems cool. But can you also remove the old golden answer file? It should be unused now.
golden/partition_based_table_scan_with_different_serde-0-8caed2a6e80250a6d38a59388679c298

@chenghao-intel
Copy link
Contributor

Oh, sorry, I saw that, it renamed.

@yhuai
Copy link
Contributor Author

yhuai commented Jul 31, 2014

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Jul 31, 2014

QA tests have started for PR 1669. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17556/consoleFull

@SparkQA
Copy link

SparkQA commented Jul 31, 2014

QA results for PR 1669:
- This patch FAILED unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17556/consoleFull

@marmbrus
Copy link
Contributor

test this please

@SparkQA
Copy link

SparkQA commented Jul 31, 2014

QA tests have started for PR 1669. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17590/consoleFull

@SparkQA
Copy link

SparkQA commented Jul 31, 2014

QA results for PR 1669:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17590/consoleFull

@marmbrus
Copy link
Contributor

Thanks for fixing this. Merged into master!

@asfgit asfgit closed this in 49b3612 Jul 31, 2014
@yhuai yhuai deleted the SPARK-2523-fixTest branch July 31, 2014 21:09
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@yhuai @conviva-zz
[SPARK-2523] [SQL] Hadoop table scan bug fixing (fix failing Jenkins …
1e6576e 
…maven test)

This PR tries to resolve the broken Jenkins maven test issue introduced by apache#1439. Now, we create a single query test to run both the setup work and the test query.

Author: Yin Huai <huai@cse.ohio-state.edu>

Closes apache#1669 from yhuai/SPARK-2523-fixTest and squashes the following commits:

358af1a [Yin Huai] Make partition_based_table_scan_with_different_serde run atomically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@yhuai @marmbrus @chenghao-intel @SparkQA