[SPARK-2379] Fix the bug that streaming's receiver may fall into a dead loop #1694
Conversation
|
Can one of the admins verify this patch? |
|
Jenkins, this is ok to test. |
| @@ -138,7 +138,7 @@ private[streaming] abstract class ReceiverSupervisor( | |||
| onReceiverStop(message, error) | |||
| } catch { | |||
| case t: Throwable => | |||
| stop("Error stopping receiver " + streamId, Some(t)) | |||
| logError("Error stopping receiver " + streamId + t.getStackTraceString) | |||
There was a problem hiding this comment.
Can you also add reportError() so that this error gets reported to the driver? Its easier to debug when all the error gets reported to the driver.
|
QA tests have started for PR 1694. This patch merges cleanly. |
|
QA results for PR 1694: |
|
Thanks. |
|
@joyyoj I am just gonna merge this and deal with reportError later. |
…ad loop Author: joyyoj <sunshch@gmail.com> Closes #1694 from joyyoj/SPARK-2379 and squashes the following commits: d73790d [joyyoj] SPARK-2379 Fix the bug that streaming's receiver may fall into a dead loop 22e7821 [joyyoj] Merge remote-tracking branch 'apache/master' 3f4a602 [joyyoj] Merge remote-tracking branch 'remotes/apache/master' f4660c5 [joyyoj] [SPARK-1998] SparkFlumeEvent with body bigger than 1020 bytes are not read properly (cherry picked from commit b270309) Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
|
@tdas Thanks for reminding me to add reportError, i didn't notice your reply before. It's a good idea to add it in this patch. |
|
Well, I have merged this patch already, in an attempt to squeeze it in 1.1 release. If you open another patch to make the change, I can try squeezing that too. Thanks for detecting and fixing this bug! |
…ad loop Author: joyyoj <sunshch@gmail.com> Closes apache#1694 from joyyoj/SPARK-2379 and squashes the following commits: d73790d [joyyoj] SPARK-2379 Fix the bug that streaming's receiver may fall into a dead loop 22e7821 [joyyoj] Merge remote-tracking branch 'apache/master' 3f4a602 [joyyoj] Merge remote-tracking branch 'remotes/apache/master' f4660c5 [joyyoj] [SPARK-1998] SparkFlumeEvent with body bigger than 1020 bytes are not read properly
No description provided.