[SPARK-15453] [SQL] [Follow-up] FileSourceScanExec to extract outputOrdering information
#16994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejasapatil
reviewed
Feb 20, 2017
| @@ -240,6 +240,7 @@ class BucketedReadSuite extends QueryTest with SQLTestUtils with TestHiveSinglet | |||
| joinCondition: (DataFrame, DataFrame) => Column, | |||
| shuffleLeft: Boolean, | |||
| shuffleRight: Boolean, | |||
| numPartitions: Int = 10, | |||
There was a problem hiding this comment.
Since other vars are for left and right side, wondering if same could to be done for numPartitions. ie. numPartitionsLeft and numPartitionsRight.
That could make the new test you added more interesting :
numPartitionsLeft = 1,
numPartitionsRight = 10,
sortLeft = false,
sortRight = true
|
Test build #73135 has finished for PR 16994 at commit
|
|
Test build #73140 has finished for PR 16994 at commit
|
|
Test build #73142 has finished for PR 16994 at commit
|
|
LGTM |
|
Thanks! Merging to master. |
Yunni
pushed a commit
to Yunni/spark
that referenced
this pull request
Feb 27, 2017
…dering` information ### What changes were proposed in this pull request? `outputOrdering` is also dependent on whether the bucket has more than one files. The test cases fail when we try to move them to sql/core. This PR is to fix the test cases introduced in apache#14864 and add a test case to verify [the related logics](https://github.com/tejasapatil/spark/blob/070c24994747c0479fb2520774ede27ff1cf8cac/sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala#L197-L206). ### How was this patch tested? N/A Author: Xiao Li <gatorsmile@gmail.com> Closes apache#16994 from gatorsmile/bucketingTS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
outputOrderingis also dependent on whether the bucket has more than one files. The test cases fail when we try to move them to sql/core. This PR is to fix the test cases introduced in #14864 and add a test case to verify the related logics.How was this patch tested?
N/A