[SPARK-19705][SQL] Preferred location supporting HDFS cache for FileS… #17035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preferred Location calculation is more complex, reflected in the code which part of it? |
…canRDD
Added support of HDFS cache using TaskLocation.inMemoryLocationTag
NewHadoopRDD and HadoopRDD both support HDFS cache using TaskLocation.inMemoryLocationTag
where "hdfs_cache_" is added to hostname which is then interpretted by scheduler
With this enhacement same tag ("hdfs_cache_") will be added to hostname if FilePartition only contains single file and the file is cached on one or more host
Current implementation would not cased where FilePartition would have multiple files as preferredLocation calculation is more complex.
tanejagagan
force-pushed
the
branch-19705
branch
from
a9288e5
to
a53ea6f
Compare
|
@hvanhovell |
rezasafi
reviewed
Jul 20, 2017
| val nonCachedLocations = files.head.locations.filterNot { x => | ||
| files.head.cachedLocations.contains(x) | ||
| }.map(HostTaskLocation(_).toString) | ||
| return cachedLocations ++ nonCachedLocations |
There was a problem hiding this comment.
Is it possible to rewrite this to avoid using return? thanks.
|
Can one of the admins verify this patch? |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…canRDD
Added support of HDFS cache using TaskLocation.inMemoryLocationTag
NewHadoopRDD and HadoopRDD both support HDFS cache using TaskLocation.inMemoryLocationTag
where "hdfs_cache_" is added to hostname which is then interpretted by scheduler
With this enhacement same tag ("hdfs_cache_") will be added to hostname if FilePartition only contains single file and the file is cached on one or more host
Current implementation would not cased where FilePartition would have multiple files as preferredLocation calculation is more complex.
What changes were proposed in this pull request?
Added support of HDFS cache using TaskLocation.inMemoryLocationTag
NewHadoopRDD and HadoopRDD both support HDFS cache using TaskLocation.inMemoryLocationTag
where "hdfs_cache_" is added to hostname which is then interpretted by scheduler
With this enhacement same tag ("hdfs_cache_") will be added to hostname if FilePartition only contains single file and the file is cached on one or more host
Current implementation would not work where FilePartition would have multiple files as preferredLocation calculation is more complex.
How was this patch tested?
Add unit tests at FileSourceStrategySuite.scala
Please review http://spark.apache.org/contributing.html before opening a pull request.