[SPARK-19841][SS]watermarkPredicate should filter based on keys #17183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #74054 has finished for PR 17183 at commit
|
marmbrus
reviewed
Mar 7, 2017
| @@ -361,7 +361,7 @@ case class StreamingDeduplicateExec( | |||
| val numUpdatedStateRows = longMetric("numUpdatedStateRows") | |||
|
|
|||
| val baseIterator = watermarkPredicate match { | |||
| case Some(predicate) => iter.filter((row: InternalRow) => !predicate.eval(row)) | |||
| case Some(predicate) => iter.filter(row => !predicate.eval(getKey(row))) | |||
There was a problem hiding this comment.
This is very minor, but maybe we should just bind a different predicate to the child.output schema rather than have two projections here.
Perhaps the base class should have both watermarkExpression and keyPredicate to allow for this flexibility.
|
LGTM |
|
Test build #74151 has finished for PR 17183 at commit
|
|
retest this please |
|
Test build #74168 has finished for PR 17183 at commit
|
|
Thanks! Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
StreamingDeduplicateExec.watermarkPredicateshould filter based on keys. Otherwise, it may generate a wrong answer if the watermark column inkeyExpressionhas a different position in the row.StateStoreSaveExechas the same codes but its parent can makes sure the watermark column positions inkeyExpressionandroware the same.How was this patch tested?
The added test.