Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-19282][ML][SparkR] RandomForest Wrapper and GBT Wrapper return param "maxDepth" to R models #17207

Closed
wants to merge 3 commits into from
Closed

[SPARK-19282][ML][SparkR] RandomForest Wrapper and GBT Wrapper return param "maxDepth" to R models #17207

wants to merge 3 commits into from

Conversation

keypointt
Copy link
Contributor

@keypointt keypointt commented Mar 8, 2017 •
edited
Loading

What changes were proposed in this pull request?

RandomForest R Wrapper and GBT R Wrapper return param maxDepth to R models.

Below 4 R wrappers are changed:

  • RandomForestClassificationWrapper
  • RandomForestRegressionWrapper
  • GBTClassificationWrapper
  • GBTRegressionWrapper

How was this patch tested?

Test manually on my local machine.

@SparkQA
Copy link

SparkQA commented Mar 8, 2017

Test build #74197 has finished for PR 17207 at commit 82612dd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Member

Can you clarify? this is on the model summary, not a param?

@keypointt
Copy link
Contributor Author

sorry being vague, I updated the PR description just now

yes, it's for R model summary, R wrapper returning maxDepth to R model
as mentioned in the comment at https://issues.apache.org/jira/browse/SPARK-19282, I don't know how to find the RandomForestRegressionModel in the R docs. R does take the parameter, but it is unclear if it exposes it on the model.

@SparkQA
Copy link

SparkQA commented Mar 8, 2017

Test build #74218 has finished for PR 17207 at commit d16b65c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Member

ok, great, could you update PR title and JIRA title then.

felixcheung
felixcheung requested changes Mar 9, 2017
View reviewed changes
Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you update the documentation on model summary in https://github.com/keypointt/spark/blob/d16b65cc077f3ba2a770d709cc8a7a9ebfda9aad/R/pkg/R/mllib_tree.R#L202

and

https://github.com/keypointt/spark/blob/d16b65cc077f3ba2a770d709cc8a7a9ebfda9aad/R/pkg/R/mllib_tree.R#L409

@keypointt keypointt changed the title [SPARK-19282][ML][SparkR] Expose model param "maxDepth" for R MLlib tree ensemble [SPARK-19282][ML][SparkR] RandomForest Wrapper and GBT Wrapper return param "maxDepth" to R models Mar 9, 2017
@SparkQA
Copy link

SparkQA commented Mar 9, 2017

Test build #74250 has finished for PR 17207 at commit 477c4bc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@keypointt
Copy link
Contributor Author

Jenkins, retest this please

@SparkQA
Copy link

SparkQA commented Mar 9, 2017

Test build #74271 has finished for PR 17207 at commit 477c4bc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@keypointt
Copy link
Contributor Author

ping @felixcheung

@felixcheung
Copy link
Member

merged to master.

@asfgit asfgit closed this in 9f8ce48 Mar 12, 2017
@facaiy facaiy mentioned this pull request May 26, 2017
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixcheung felixcheung felixcheung requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@keypointt @SparkQA @felixcheung