Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-2801][MLlib]: DistributionGenerator renamed to RandomDataGenerator. RandomRDD is now of generic type #1732

Closed
wants to merge 2 commits into from
Closed

[SPARK-2801][MLlib]: DistributionGenerator renamed to RandomDataGenerator. RandomRDD is now of generic type #1732

wants to merge 2 commits into from

Conversation

brkyvz
Copy link
Contributor

@brkyvz brkyvz commented Aug 2, 2014

The RandomRDDGenerators used to only output RDD[Double].
Now RandomRDDGenerators.randomRDD can be used to generate a random RDD[T] via a class that extends RandomDataGenerator, by supplying a type T and overriding the nextValue() function as they wish.

@brkyvz
[SPARK-2801][MLlib]: DistributionGenerator renamed to RandomDataGener…
22d96fe 
…ator, generic types added for RandomRDD instead of Double
@SparkQA
Copy link

SparkQA commented Aug 2, 2014

QA tests have started for PR 1732. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17742/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 2, 2014

QA results for PR 1732:
- This patch FAILED unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17742/consoleFull

@mengxr
Copy link
Contributor

mengxr commented Aug 2, 2014

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Aug 2, 2014

QA tests have started for PR 1732. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17743/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 2, 2014

QA results for PR 1732:
- This patch FAILED unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17743/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 2, 2014

QA tests have started for PR 1732. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17745/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 2, 2014

QA results for PR 1732:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17745/consoleFull

@mengxr
Copy link
Contributor

mengxr commented Aug 2, 2014

LGTM. Merged into master. Thanks!

@asfgit asfgit closed this in fda4759 Aug 2, 2014
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@brkyvz @conviva-zz
[SPARK-2801][MLlib]: DistributionGenerator renamed to RandomDataGener…
d8601cc 
…ator. RandomRDD is now of generic type

The RandomRDDGenerators used to only output RDD[Double].
Now RandomRDDGenerators.randomRDD can be used to generate a random RDD[T] via a class that extends RandomDataGenerator, by supplying a type T and overriding the nextValue() function as they wish.

Author: Burak <brkyvz@gmail.com>

Closes apache#1732 from brkyvz/SPARK-2801 and squashes the following commits:

c94a694 [Burak] [SPARK-2801][MLlib] Missing ClassTags added
22d96fe [Burak] [SPARK-2801][MLlib]: DistributionGenerator renamed to RandomDataGenerator, generic types added for RandomRDD instead of Double
@brkyvz brkyvz deleted the SPARK-2801 branch January 30, 2015 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@brkyvz @SparkQA @mengxr