[SPARK-19721][SS][BRANCH-2.1] Good error message for version mismatch in log files #17327
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are several places where we write out version identifiers in various logs for structured streaming (usually
v1
). However, in the places where we check for this, we throw a confusing error message.What changes were proposed in this pull request?
This patch made two major changes:
parseVersion(...)
method, and based on this method, fixed the following places the way they did version checking (no other place needed to do this checking):FileStreamSinkLog.VERSION
,FileStreamSourceLog.VERSION
etc. fromString
toInt
, so that we can identify newer versions viaversion > 1
instead ofversion != "v1"
"v1"
and reading back"v1"
Exception message with this patch
How was this patch tested?
unit tests