Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor] Fixes on top of #1679 #1736

Closed
wants to merge 1 commit into from
Closed

[Minor] Fixes on top of #1679 #1736

wants to merge 1 commit into from

Conversation

andrewor14
Copy link
Contributor

Minor fixes on top of #1679.

@SparkQA
Copy link

SparkQA commented Aug 2, 2014

QA tests have started for PR 1736. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17762/consoleFull

mridulm
mridulm reviewed Aug 2, 2014
View reviewed changes
core/src/main/scala/org/apache/spark/storage/BlockManagerSource.scala
val remainingMem = storageStatusList.map(_.memRemaining).sum
(maxMem - remainingMem) / 1024 / 1024
val memUsed = storageStatusList.map(_.memUsed).sum
memUsed / 1024 / 1024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: / (1024 * 1024) instead ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do the double slash in other places as well. Changing those too would touch upon things I didn't touch in #1679, so I'd rather keep the changes in this PR at the minimum while keeping the code consistent with the other places in this file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad code is bad code :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, it is just a nit - so please dont let this block a commit !

@SparkQA
Copy link

SparkQA commented Aug 2, 2014

QA results for PR 1736:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17762/consoleFull

asfgit pushed a commit that referenced this pull request Aug 3, 2014
@andrewor14 @pwendell
[Minor] Fixes on top of #1679
fb2a207 
Minor fixes on top of #1679.

Author: Andrew Or <andrewor14@gmail.com>

Closes #1736 from andrewor14/amend-#1679 and squashes the following commits:

3b46f5e [Andrew Or] Minor fixes
(cherry picked from commit 3dc55fd)

Signed-off-by: Patrick Wendell <pwendell@gmail.com>
@asfgit asfgit closed this in 3dc55fd Aug 3, 2014
@andrewor14 andrewor14 deleted the amend-#1679 branch August 4, 2014 19:06
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@andrewor14 @conviva-zz
[Minor] Fixes on top of apache#1679
b1fefef 
Minor fixes on top of apache#1679.

Author: Andrew Or <andrewor14@gmail.com>

Closes apache#1736 from andrewor14/amend-#1679 and squashes the following commits:

3b46f5e [Andrew Or] Minor fixes
sunchao pushed a commit to sunchao/spark that referenced this pull request Jun 2, 2023
@huaxingao
rdar://108145465 (Bump Boson to 0.3.1 for ACS Spark 3.2) (apache#1736)
9ce23e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@andrewor14 @SparkQA @mridulm