Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] [SQL] Fix the failed test cases in GeneratorFunctionSuite #17425

Closed

Conversation

gatorsmile
Copy link
Member

What changes were proposed in this pull request?

Multiple tests failed. Revert the changes on supportCodegen of GenerateExec. For example,

How was this patch tested?

N/A

@gatorsmile gatorsmile changed the title [HOTFIX] [BUILD] Revert changes on supportCodegen of GenerateExec [HOTFIX] [TEST] Revert changes on supportCodegen of GenerateExec Mar 25, 2017
@gatorsmile gatorsmile changed the title [HOTFIX] [TEST] Revert changes on supportCodegen of GenerateExec [HOTFIX] [SQL] Revert changes on supportCodegen of GenerateExec Mar 25, 2017
@gatorsmile
Copy link
Member Author

cc @rxin

@gatorsmile
Copy link
Member Author

gatorsmile commented Mar 25, 2017

It sounds like the codegen version has a bug. It did not respect the following logics:

@param outer when true, each input row will be output at least once, even if the output of the
             given `generator` is empty. `outer` has no effect when `join` is false.

@gatorsmile gatorsmile changed the title [HOTFIX] [SQL] Revert changes on supportCodegen of GenerateExec [HOTFIX] [SQL] Disable the failed test cases in GeneratorFunctionSuite Mar 25, 2017
@gatorsmile gatorsmile changed the title [HOTFIX] [SQL] Disable the failed test cases in GeneratorFunctionSuite [HOTFIX] [SQL] Fix the failed test cases in GeneratorFunctionSuite Mar 25, 2017
@SparkQA
Copy link

SparkQA commented Mar 25, 2017

Test build #75203 has finished for PR 17425 at commit f9d9082.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Mar 25, 2017

Test build #75204 has finished for PR 17425 at commit 48b73db.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Mar 25, 2017

Test build #75206 has finished for PR 17425 at commit 206370d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member Author

gatorsmile commented Mar 25, 2017

Merging to master!

@asfgit asfgit closed this in a2ce0a2 Mar 25, 2017
@viirya
Copy link
Member

viirya commented Aug 11, 2017

@gatorsmile I'm exploring Generate related code. I'm curious why you don't revert the supportCodegen back in the end?

@kiszk
Copy link
Member

kiszk commented Dec 20, 2017

@gatorsmile I have the same question. Which operation in Generator is bad? All of them, or only one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants