Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-2627] [PySpark] have the build enforce PEP 8 automatically #1744

Closed
wants to merge 28 commits into from
Closed

[SPARK-2627] [PySpark] have the build enforce PEP 8 automatically #1744

wants to merge 28 commits into from

Commits on Aug 2, 2014

  1. make check output style consistent

    The RAT and PEP8 checks don’t print a blank line after successful runs.
    The scalastyle check shouldn’t either.
    nchammas committed Aug 2, 2014
    Configuration menu
    Copy the full SHA
    75ad552 View commit details
    Browse the repository at this point in the history
  2. [SPARK-2627] add Python linter

    This guy just runs the pep8 utility on all code in the python
    directory, minus cloudpickle, which is a 3rd-party library.
    nchammas committed Aug 2, 2014
    Configuration menu
    Copy the full SHA
    61c07b9 View commit details
    Browse the repository at this point in the history
  3. [SPARK-2627] add Scala linter

    This guy just calls scalastyle.
    nchammas committed Aug 2, 2014
    Configuration menu
    Copy the full SHA
    12440fa View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0541ebb View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    723ed39 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2014

  1. Configuration menu
    Copy the full SHA
    beaa9ac View commit details
    Browse the repository at this point in the history
  2. [SPARK-2627] miscellaneous PEP 8 fixes

    Mostly done using autopep8, plus some hand fixes.
    nchammas committed Aug 3, 2014
    Configuration menu
    Copy the full SHA
    a31ccc4 View commit details
    Browse the repository at this point in the history
  3. resolving merge conflicts

    *fingers crossed*
    
    I admit I’m not exactly sure how this works… Let’s see if I did the
    right thing.
    nchammas committed Aug 3, 2014
    Configuration menu
    Copy the full SHA
    9a66cb0 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #1 from apache/master

    merge upstream changes
    nchammas committed Aug 3, 2014
    Configuration menu
    Copy the full SHA
    9c01d4c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fe57ed0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6f4900b View commit details
    Browse the repository at this point in the history
  7. [SPARK-2627] it's PEP 8, not PEP8

    Minor, I know.
    nchammas committed Aug 3, 2014
    Configuration menu
    Copy the full SHA
    21da538 View commit details
    Browse the repository at this point in the history
  8. [SPARK-2627] space out test report sections

    Everything looks cramped and it’s hard to tell at a glance where
    sections begin. Adding a blank line between sections should fix that.
    nchammas committed Aug 3, 2014
    Configuration menu
    Copy the full SHA
    a1ce7ae View commit details
    Browse the repository at this point in the history
  9. [SPARK-2627] download pep8 at runtime

    See the discussion here:
    #1744 (comment)
    
    Get the pep8 utility at runtime so that it’s not required to be
    installed on the build server.
    nchammas committed Aug 3, 2014
    Configuration menu
    Copy the full SHA
    dffb5dd View commit details
    Browse the repository at this point in the history
  10. [SPARK-2627] check that pep8 downloaded fine

    Don’t just assume curl got the file alright. Check and exit properly if
    there were any problems.
    nchammas committed Aug 3, 2014
    Configuration menu
    Copy the full SHA
    d0a83b9 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2014

  1. [SPARK-2627] follow Spark bash style for if blocks

    “then” goes on the same line as the opening “if”.
    nchammas committed Aug 4, 2014
    Configuration menu
    Copy the full SHA
    aa5b4b5 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2 from apache/master

    merge upstream changes
    nchammas committed Aug 4, 2014
    Configuration menu
    Copy the full SHA
    9da347f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bfb9f9f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b09fae2 View commit details
    Browse the repository at this point in the history
  5. [SPARK-2627] use tox.ini to exclude files

    No need to exclude files in the call to pep8. The tool references
    tox.ini for config information, so we should use that.
    nchammas committed Aug 4, 2014
    Configuration menu
    Copy the full SHA
    44e3e56 View commit details
    Browse the repository at this point in the history
  6. [SPARK-2627] undo unnecessary line breaks

    “Undo” unnecessary line breaks introduced by accident when I called
    autopep8 on the whole Python directory without setting the max line
    length to 100. (autopep8 defaults to 79.)
    nchammas committed Aug 4, 2014
    Configuration menu
    Copy the full SHA
    91b7584 View commit details
    Browse the repository at this point in the history
  7. merge upstream changes

    nchammas committed Aug 4, 2014
    Configuration menu
    Copy the full SHA
    7b4750e View commit details
    Browse the repository at this point in the history
  8. Merge pull request #3 from apache/master

    [SPARK-1687] [PySpark] fix unit tests related to pickable namedtuple
    nchammas committed Aug 4, 2014
    Configuration menu
    Copy the full SHA
    6db9a44 View commit details
    Browse the repository at this point in the history
  9. [SPARK-2627] PEP8: comment spacing

    PEP 8 is the bee’s knees.
    nchammas committed Aug 4, 2014
    Configuration menu
    Copy the full SHA
    bf30942 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2014

  1. Configuration menu
    Copy the full SHA
    0e0245f View commit details
    Browse the repository at this point in the history
  2. Merge pull request #4 from apache/master

    merge upstream changes
    nchammas committed Aug 5, 2014
    Configuration menu
    Copy the full SHA
    1db5314 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2014

  1. Merge pull request #5 from apache/master

    merge upstream changes
    nchammas committed Aug 6, 2014
    Configuration menu
    Copy the full SHA
    983d963 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    274b238 View commit details
    Browse the repository at this point in the history