[MINOR][DOCS] Replace non-breaking space to normal spaces that breaks rendering markdown #17517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
commented
Apr 3, 2017
| @@ -257,7 +257,7 @@ In the API, an application is referenced by its application ID, `[app-id]`. | |||
| When running on YARN, each application may have multiple attempts, but there are attempt IDs | |||
| only for applications in cluster mode, not applications in client mode. Applications in YARN cluster mode | |||
| can be identified by their `[attempt-id]`. In the API listed below, when running in YARN cluster mode, | |||
| `[app-id]` will actually be `[base-app-id]/[attempt-id]`, where `[base-app-id]` is the YARN application ID. | |||
| `[app-id]` will actually be `[base-app-id]/[attempt-id]`, where `[base-app-id]` is the YARN application ID. | |||
There was a problem hiding this comment.
These seems mistakenly added. So, I decided to fix it here.
There was a problem hiding this comment.
Open a vi and copy it and print it within python to verify this.
>>> "`[app-id]` will actually be `[base-app-id]/[attempt-id]`, where `[base-app-id]` is the YARN application ID"
'`[app-id]`\xc2\xa0will actually be\xc2\xa0`[base-app-id]/[attempt-id]`, where `[base-app-id]`\xc2\xa0is the YARN application ID'
|
cc @srowen. Could you take a look please? |
HyukjinKwon
commented
Apr 3, 2017
| @@ -154,7 +154,7 @@ Developers who compile Spark frequently may want to speed up compilation; e.g., | |||
| developers who build with SBT). For more information about how to do this, refer to the | |||
| [Useful Developer Tools page](http://spark.apache.org/developer-tools.html#reducing-build-times). | |||
|
|
|||
| ## Encrypted Filesystems | |||
| ## Encrypted Filesystems | |||
There was a problem hiding this comment.
>>> "## Encrypted Filesystems"
'##\xc2\xa0Encrypted Filesystems'
HyukjinKwon
commented
Apr 3, 2017
| @@ -97,7 +97,7 @@ building for particular Hive and Hive Thriftserver distributions. | |||
| Please refer to the [Configuration Guide](http://spark.apache.org/docs/latest/configuration.html) | |||
| in the online documentation for an overview on how to configure Spark. | |||
|
|
|||
| ## Contributing | |||
| ## Contributing | |||
There was a problem hiding this comment.
>>> "## Contributing"
'##\xc2\xa0Contributing'
|
Test build #75471 has finished for PR 17517 at commit
|
srowen
approved these changes
Apr 3, 2017
|
Merged to master/2.1 |
asfgit
pushed a commit
that referenced
this pull request
Apr 3, 2017
… rendering markdown # What changes were proposed in this pull request? It seems there are several non-breaking spaces were inserted into several `.md`s and they look breaking rendering markdown files. These are different. For example, this can be checked via `python` as below: ```python >>> " " '\xc2\xa0' >>> " " ' ' ``` _Note that it seems this PR description automatically replaces non-breaking spaces into normal spaces. Please open a `vi` and copy and paste it into `python` to verify this (do not copy the characters here)._ I checked the output below in Sapari and Chrome on Mac OS and, Internal Explorer on Windows 10. **Before**   **After**   ## How was this patch tested? Manually checking. These instances were found via ``` grep --include=*.scala --include=*.python --include=*.java --include=*.r --include=*.R --include=*.md --include=*.r -r -I " " . ``` in Mac OS. It seems there are several instances more as below: ``` ./docs/sql-programming-guide.md: │ ├── ... ./docs/sql-programming-guide.md: │ │ ./docs/sql-programming-guide.md: │ ├── country=US ./docs/sql-programming-guide.md: │ │ └── data.parquet ./docs/sql-programming-guide.md: │ ├── country=CN ./docs/sql-programming-guide.md: │ │ └── data.parquet ./docs/sql-programming-guide.md: │ └── ... ./docs/sql-programming-guide.md: ├── ... ./docs/sql-programming-guide.md: │ ./docs/sql-programming-guide.md: ├── country=US ./docs/sql-programming-guide.md: │ └── data.parquet ./docs/sql-programming-guide.md: ├── country=CN ./docs/sql-programming-guide.md: │ └── data.parquet ./docs/sql-programming-guide.md: └── ... ./sql/core/src/test/README.md:│ ├── *.avdl # Testing Avro IDL(s) ./sql/core/src/test/README.md:│ └── *.avpr # !! NO TOUCH !! Protocol files generated from Avro IDL(s) ./sql/core/src/test/README.md:│ ├── gen-avro.sh # Script used to generate Java code for Avro ./sql/core/src/test/README.md:│ └── gen-thrift.sh # Script used to generate Java code for Thrift ``` These seems generated via `tree` command which inserts non-breaking spaces. They do not look causing any problem for rendering within code blocks and I did not fix it to reduce the overhead to manually replace it when it is overwritten via `tree` command in the future. Author: hyukjinkwon <gurwls223@gmail.com> Closes #17517 from HyukjinKwon/non-breaking-space. (cherry picked from commit 364b0db) Signed-off-by: Sean Owen <sowen@cloudera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It seems there are several non-breaking spaces were inserted into several
.mds and they look breaking rendering markdown files.These are different. For example, this can be checked via
pythonas below:Note that it seems this PR description automatically replaces non-breaking spaces into normal spaces. Please open a
viand copy and paste it intopythonto verify this (do not copy the characters here).I checked the output below in Sapari and Chrome on Mac OS and, Internal Explorer on Windows 10.
Before
After
How was this patch tested?
Manually checking.
These instances were found via
in Mac OS.
It seems there are several instances more as below:
These seems generated via
treecommand which inserts non-breaking spaces. They do not look causing any problem for rendering within code blocks and I did not fix it to reduce the overhead to manually replace it when it is overwritten viatreecommand in the future.