Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR][DOCS] Fix spacings in Structured Streaming Programming Guide #17564

Closed

Conversation

dongjinleekr
Copy link
Contributor

What changes were proposed in this pull request?

  1. Omitted space between the sentences: ... on static data.The Spark SQL engine will ... -> ... on static data. The Spark SQL engine will ...
  2. Omitted colon in Output Model section.

How was this patch tested?

None.

@srowen
Copy link
Member

srowen commented Apr 7, 2017

Please review the rest of the docs for simple typos like this too. Better to get it done in one go.

@dongjinleekr
Copy link
Contributor Author

No problem! I will notify you after the review.

@srowen
Copy link
Member

srowen commented Apr 11, 2017

Ping @dongjinleekr do you have any other typos to report? if not, after a reasonable review, this can be just merged.

@SparkQA
Copy link

SparkQA commented Apr 11, 2017

Test build #3656 has finished for PR 17564 at commit e10843d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjinleekr
Copy link
Contributor Author

@srowen I just completed the review. I could not find any other typos from this document. :)

@srowen
Copy link
Member

srowen commented Apr 12, 2017

Merged to master/2.1

asfgit pushed a commit that referenced this pull request Apr 12, 2017
## What changes were proposed in this pull request?

1. Omitted space between the sentences: `... on static data.The Spark SQL engine will ...` -> `... on static data. The Spark SQL engine will ...`
2. Omitted colon in Output Model section.

## How was this patch tested?

None.

Author: Lee Dongjin <dongjin@apache.org>

Closes #17564 from dongjinleekr/feature/fix-programming-guide.

(cherry picked from commit b938438)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@asfgit asfgit closed this in b938438 Apr 12, 2017
peter-toth pushed a commit to peter-toth/spark that referenced this pull request Oct 6, 2018
## What changes were proposed in this pull request?

1. Omitted space between the sentences: `... on static data.The Spark SQL engine will ...` -> `... on static data. The Spark SQL engine will ...`
2. Omitted colon in Output Model section.

## How was this patch tested?

None.

Author: Lee Dongjin <dongjin@apache.org>

Closes apache#17564 from dongjinleekr/feature/fix-programming-guide.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants