Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-20262][SQL] AssertNotNull should throw NullPointerException #17573

Closed
wants to merge 1 commit into from
Closed

[SPARK-20262][SQL] AssertNotNull should throw NullPointerException #17573

wants to merge 1 commit into from

Conversation

rxin
Copy link
Contributor

@rxin rxin commented Apr 8, 2017

What changes were proposed in this pull request?

AssertNotNull currently throws RuntimeException. It should throw NullPointerException, which is more specific.

How was this patch tested?

N/A

@SparkQA
Copy link

SparkQA commented Apr 8, 2017

Test build #75617 has finished for PR 17573 at commit 4c16795.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • case class AssertNotNull(child: Expression, walkedTypePath: Seq[String] = Nil)

gatorsmile
gatorsmile approved these changes Apr 8, 2017
View reviewed changes
Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit closed this in e1afc4d Apr 8, 2017
asfgit pushed a commit that referenced this pull request Apr 8, 2017
@rxin @gatorsmile
[SPARK-20262][SQL] AssertNotNull should throw NullPointerException
658b358 
AssertNotNull currently throws RuntimeException. It should throw NullPointerException, which is more specific.

N/A

Author: Reynold Xin <rxin@databricks.com>

Closes #17573 from rxin/SPARK-20262.

(cherry picked from commit e1afc4d)
Signed-off-by: Xiao Li <gatorsmile@gmail.com>
@gatorsmile
Copy link
Member

Thanks! Merging to master/2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatorsmile gatorsmile gatorsmile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rxin @SparkQA @gatorsmile