Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-20543][SPARKR][FOLLOWUP] Don't skip tests on AppVeyor #17878

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/pkg/inst/tests/testthat/test_sparkSQL.R
Original file line number Diff line number Diff line change
Expand Up @@ -3387,7 +3387,7 @@ compare_list <- function(list1, list2) {

# This should always be the **very last test** in this test file.
test_that("No extra files are created in SPARK_HOME by starting session and making calls", {
skip_on_cran()
skip_on_cran() # skip because when run from R CMD check SPARK_HOME is not the current directory

# Check that it is not creating any extra file.
# Does not check the tempdir which would be cleaned up after.
Expand Down
4 changes: 3 additions & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ install:
build_script:
- cmd: mvn -DskipTests -Psparkr -Phive -Phive-thriftserver package

environment:
NOT_CRAN: true

test_script:
- cmd: .\bin\spark-submit2.cmd --driver-java-options "-Dlog4j.configuration=file:///%CD:\=/%/R/log4j.properties" --conf spark.hadoop.fs.defaultFS="file:///" R\pkg\tests\run-all.R

Expand All @@ -56,4 +59,3 @@ notifications:
on_build_success: false
on_build_failure: false
on_build_status_changed: false