-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-20630] [Web UI] Fixed column visibility in Executor Tab #17904
Conversation
Test build #76594 has finished for PR 17904 at commit
|
Jenkins, retest this please |
Please rebase to pick up fix for R tests |
This is kinda weird - I don't know why it's running R tests |
Test build #76607 has finished for PR 17904 at commit
|
Jenkins, retest this please |
I'm not sure why it's failing those tests, plus my branch is up to date with master (minus one unrelated commit) |
Test build #76620 has started for PR 17904 at commit |
WFM. Thanks @ajbozarth!
The following worked fine (http://localhost:4040/executors/):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked fine! Thanks.
Jenkins, retest this please |
weird test failure and thanks for the review @jaceklaskowski |
Test build #76692 has finished for PR 17904 at commit
|
@srowen passed test, this good to merge? |
Merged to master/2.2 |
## What changes were proposed in this pull request? #14617 added new columns to the executor table causing the visibility checks for the logs and threadDump columns to toggle the wrong columns since they used hard-coded column numbers. I've updated the checks to use column names instead of numbers so future updates don't accidentally break this again. Note: This will also need to be back ported into 2.2 since #14617 was merged there ## How was this patch tested? Manually tested Author: Alex Bozarth <ajbozart@us.ibm.com> Closes #17904 from ajbozarth/spark20630. (cherry picked from commit ca4625e) Signed-off-by: Sean Owen <sowen@cloudera.com>
## What changes were proposed in this pull request? apache#14617 added new columns to the executor table causing the visibility checks for the logs and threadDump columns to toggle the wrong columns since they used hard-coded column numbers. I've updated the checks to use column names instead of numbers so future updates don't accidentally break this again. Note: This will also need to be back ported into 2.2 since apache#14617 was merged there ## How was this patch tested? Manually tested Author: Alex Bozarth <ajbozart@us.ibm.com> Closes apache#17904 from ajbozarth/spark20630.
What changes were proposed in this pull request?
#14617 added new columns to the executor table causing the visibility checks for the logs and threadDump columns to toggle the wrong columns since they used hard-coded column numbers.
I've updated the checks to use column names instead of numbers so future updates don't accidentally break this again.
Note: This will also need to be back ported into 2.2 since #14617 was merged there
How was this patch tested?
Manually tested