Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[SPARK-20606][ML] ML 2.2 QA: Remove deprecated methods for ML" #17944

Closed
wants to merge 1 commit into from
Closed

Revert "[SPARK-20606][ML] ML 2.2 QA: Remove deprecated methods for ML" #17944

wants to merge 1 commit into from

Conversation

yanboliang
Copy link
Contributor

@yanboliang yanboliang commented May 11, 2017 •
edited
Loading

This reverts commit b8733e0.

felixcheung
felixcheung reviewed May 11, 2017
View reviewed changes
mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala
* @deprecated This method is deprecated and will be removed in 2.2.0.
* @group setParam
*/
@deprecated("This method is deprecated and will be removed in 2.2.0.", "2.1.0")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this PR not for the 2.2.0 release?

@felixcheung
Copy link
Member

ok I saw #17867

@SparkQA
Copy link

SparkQA commented May 11, 2017

Test build #76768 has finished for PR 17944 at commit 185478c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request May 11, 2017
@yanboliang
[SPARK-20606][ML] Revert "[] ML 2.2 QA: Remove deprecated methods for…
80a57fa 
… ML"

This reverts commit b8733e0.

Author: Yanbo Liang <ybliang8@gmail.com>

Closes #17944 from yanboliang/spark-20606-revert.

(cherry picked from commit 0698e6c)
Signed-off-by: Yanbo Liang <ybliang8@gmail.com>
@asfgit asfgit closed this in 0698e6c May 11, 2017
@yanboliang yanboliang deleted the spark-20606-revert branch May 11, 2017 06:52
@jkbradley
Copy link
Member

Thanks a lot @yanboliang !

liyichao pushed a commit to liyichao/spark that referenced this pull request May 24, 2017
@yanboliang @liyichao
[SPARK-20606][ML] Revert "[] ML 2.2 QA: Remove deprecated methods for…
8e806b7 
… ML"

This reverts commit b8733e0.

Author: Yanbo Liang <ybliang8@gmail.com>

Closes apache#17944 from yanboliang/spark-20606-revert.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixcheung felixcheung felixcheung left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@yanboliang @felixcheung @SparkQA @jkbradley