[SPARK-20718][SQL] FileSourceScanExec with different filter orders should be the same after canonicalization #17959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also cc @gatorsmile |
|
LGTM |
|
Test build #76843 has finished for PR 17959 at commit
|
gatorsmile
reviewed
May 12, 2017
| None) | ||
| } | ||
|
|
||
| private def canonicalizeFilters(filters: Seq[Expression], output: Seq[Attribute]) |
|
How about |
asfgit
pushed a commit
that referenced
this pull request
May 12, 2017
…ould be the same after canonicalization ## What changes were proposed in this pull request? Since `constraints` in `QueryPlan` is a set, the order of filters can differ. Usually this is ok because of canonicalization. However, in `FileSourceScanExec`, its data filters and partition filters are sequences, and their orders are not canonicalized. So `def sameResult` returns different results for different orders of data/partition filters. This leads to, e.g. different decision for `ReuseExchange`, and thus results in unstable performance. ## How was this patch tested? Added a new test for `FileSourceScanExec.sameResult`. Author: wangzhenhua <wangzhenhua@huawei.com> Closes #17959 from wzhfy/canonicalizeFileSourceScanExec. (cherry picked from commit c8da535) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
|
merged to master/2.2, please send a follow-up PR to address @gatorsmile 's comments, thanks! |
|
@gatorsmile Right, thanks for pointing this out! |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
May 19, 2017
…ould be the same after canonicalization ## What changes were proposed in this pull request? Since `constraints` in `QueryPlan` is a set, the order of filters can differ. Usually this is ok because of canonicalization. However, in `FileSourceScanExec`, its data filters and partition filters are sequences, and their orders are not canonicalized. So `def sameResult` returns different results for different orders of data/partition filters. This leads to, e.g. different decision for `ReuseExchange`, and thus results in unstable performance. ## How was this patch tested? Added a new test for `FileSourceScanExec.sameResult`. Author: wangzhenhua <wangzhenhua@huawei.com> Closes apache#17959 from wzhfy/canonicalizeFileSourceScanExec.
liyichao
pushed a commit
to liyichao/spark
that referenced
this pull request
May 24, 2017
…ould be the same after canonicalization ## What changes were proposed in this pull request? Since `constraints` in `QueryPlan` is a set, the order of filters can differ. Usually this is ok because of canonicalization. However, in `FileSourceScanExec`, its data filters and partition filters are sequences, and their orders are not canonicalized. So `def sameResult` returns different results for different orders of data/partition filters. This leads to, e.g. different decision for `ReuseExchange`, and thus results in unstable performance. ## How was this patch tested? Added a new test for `FileSourceScanExec.sameResult`. Author: wangzhenhua <wangzhenhua@huawei.com> Closes apache#17959 from wzhfy/canonicalizeFileSourceScanExec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Since
constraintsinQueryPlanis a set, the order of filters can differ. Usually this is ok because of canonicalization. However, inFileSourceScanExec, its data filters and partition filters are sequences, and their orders are not canonicalized. Sodef sameResultreturns different results for different orders of data/partition filters. This leads to, e.g. different decision forReuseExchange, and thus results in unstable performance.How was this patch tested?
Added a new test for
FileSourceScanExec.sameResult.