Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MLlib] Use this.type as return type in k-means' builder pattern #1796

Closed
wants to merge 1 commit into from
Closed

[MLlib] Use this.type as return type in k-means' builder pattern #1796

wants to merge 1 commit into from

Conversation

dbtsai
Copy link
Member

@dbtsai dbtsai commented Aug 6, 2014

to ensure that the return object is itself.

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA tests have started for PR 1796. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17969/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA results for PR 1796:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17969/consoleFull

@mengxr
Copy link
Contributor

mengxr commented Aug 6, 2014

LGTM. Merged into both master and branch-1.1. Thanks!!

asfgit pushed a commit that referenced this pull request Aug 6, 2014
@mengxr
[MLlib] Use this.type as return type in k-means' builder pattern
aec217a 
to ensure that the return object is itself.

Author: DB Tsai <dbtsai@alpinenow.com>

Closes #1796 from dbtsai/dbtsai-kmeans and squashes the following commits:

658989e [DB Tsai] Alpine Data Labs

(cherry picked from commit c7b5201)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@asfgit asfgit closed this in c7b5201 Aug 6, 2014
@dbtsai dbtsai deleted the dbtsai-kmeans branch August 11, 2014 22:34
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@conviva-zz
[MLlib] Use this.type as return type in k-means' builder pattern
bcf834d 
to ensure that the return object is itself.

Author: DB Tsai <dbtsai@alpinenow.com>

Closes apache#1796 from dbtsai/dbtsai-kmeans and squashes the following commits:

658989e [DB Tsai] Alpine Data Labs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dbtsai @SparkQA @mengxr