[SPARK-20700][SQL] InferFiltersFromConstraints stackoverflows for query (v2) #18020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiangxb1987
commented
May 17, 2017
| @@ -172,30 +173,27 @@ class InferFiltersFromConstraintsSuite extends PlanTest { | |||
| val t1 = testRelation.subquery('t1) | |||
| val t2 = testRelation.subquery('t2) | |||
|
|
|||
| val originalQuery = t1.select('a, 'b.as('d), Coalesce(Seq('a, 'b)).as('int_col)).as("t") | |||
| val originalQuery = t1.select('a, 'b.as('d), Coalesce(Seq('a, 'b)).as('int_col)) | |||
There was a problem hiding this comment.
The modified test case would have failed on current master branch.
There was a problem hiding this comment.
How about keeping the existing test case untouched? Adding a new test case?
There was a problem hiding this comment.
Then they would look much the same... The modified test case also covers the original situation, so I think it may be okay to not add new test cases.
|
Test build #77027 has finished for PR 18020 at commit
|
gatorsmile
reviewed
May 17, 2017
| @@ -82,10 +82,10 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]] extends TreeNode[PlanT | |||
| } | |||
|
|
|||
| // Collect aliases from expressions, so we may avoid producing recursive constraints. | |||
| private lazy val aliasMap = AttributeMap( | |||
| (expressions ++ children.flatMap(_.expressions)).collect { | |||
| protected lazy val aliasMap: AttributeMap[Expression] = AttributeMap( | |||
|
LGTM |
|
Test build #77031 has finished for PR 18020 at commit
|
|
Test build #77035 has finished for PR 18020 at commit
|
asfgit
pushed a commit
that referenced
this pull request
May 18, 2017
…ry (v2) ## What changes were proposed in this pull request? In the previous approach we used `aliasMap` to link an `Attribute` to the expression with potentially the form `f(a, b)`, but we only searched the `expressions` and `children.expressions` for this, which is not enough when an `Alias` may lies deep in the logical plan. In that case, we can't generate the valid equivalent constraint classes and thus we fail at preventing the recursive deductions. We fix this problem by collecting all `Alias`s from the logical plan. ## How was this patch tested? No additional test case is added, but do modified one test case to cover this situation. Author: Xingbo Jiang <xingbo.jiang@databricks.com> Closes #18020 from jiangxb1987/inferConstrants. (cherry picked from commit b7aac15) Signed-off-by: Xiao Li <gatorsmile@gmail.com>
|
Thanks! Merging to master/2.2. |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
May 19, 2017
…ry (v2) ## What changes were proposed in this pull request? In the previous approach we used `aliasMap` to link an `Attribute` to the expression with potentially the form `f(a, b)`, but we only searched the `expressions` and `children.expressions` for this, which is not enough when an `Alias` may lies deep in the logical plan. In that case, we can't generate the valid equivalent constraint classes and thus we fail at preventing the recursive deductions. We fix this problem by collecting all `Alias`s from the logical plan. ## How was this patch tested? No additional test case is added, but do modified one test case to cover this situation. Author: Xingbo Jiang <xingbo.jiang@databricks.com> Closes apache#18020 from jiangxb1987/inferConstrants.
liyichao
pushed a commit
to liyichao/spark
that referenced
this pull request
May 24, 2017
…ry (v2) ## What changes were proposed in this pull request? In the previous approach we used `aliasMap` to link an `Attribute` to the expression with potentially the form `f(a, b)`, but we only searched the `expressions` and `children.expressions` for this, which is not enough when an `Alias` may lies deep in the logical plan. In that case, we can't generate the valid equivalent constraint classes and thus we fail at preventing the recursive deductions. We fix this problem by collecting all `Alias`s from the logical plan. ## How was this patch tested? No additional test case is added, but do modified one test case to cover this situation. Author: Xingbo Jiang <xingbo.jiang@databricks.com> Closes apache#18020 from jiangxb1987/inferConstrants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the previous approach we used
aliasMapto link anAttributeto the expression with potentially the formf(a, b), but we only searched theexpressionsandchildren.expressionsfor this, which is not enough when anAliasmay lies deep in the logical plan. In that case, we can't generate the valid equivalent constraint classes and thus we fail at preventing the recursive deductions.We fix this problem by collecting all
Aliass from the logical plan.How was this patch tested?
No additional test case is added, but do modified one test case to cover this situation.