Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-19281][FOLLOWUP][ML] Minor fix for PySpark FPGrowth. #18089

Closed
wants to merge 1 commit into from

Conversation

yanboliang
Copy link
Contributor

@yanboliang yanboliang commented May 24, 2017

What changes were proposed in this pull request?

Follow-up for #17218, some minor fix for PySpark FPGrowth.

How was this patch tested?

Existing UT.

Copy link
Contributor Author

@yanboliang yanboliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

times will be output""",
"Minimal support level of the frequent pattern. [0.0, 1.0]. " +
"Any pattern that appears more than (minSupport * size-of-the-dataset) " +
"times will be output in the frequent itemsets.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note there will be \n in the generated Python API docs if using """.

Before this PR:
image

After this PR:
image

@SparkQA
Copy link

SparkQA commented May 24, 2017

Test build #77303 has finished for PR 18089 at commit 36ab5a5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class HasMinSupport(Params):
  • class HasMinConfidence(Params):

@zero323
Copy link
Member

zero323 commented May 24, 2017

Thanks @yanboliang

@yanboliang
Copy link
Contributor Author

Merged into master and branch-2.2. Thanks for reviewing.

asfgit pushed a commit that referenced this pull request May 25, 2017
## What changes were proposed in this pull request?
Follow-up for #17218, some minor fix for PySpark ```FPGrowth```.

## How was this patch tested?
Existing UT.

Author: Yanbo Liang <ybliang8@gmail.com>

Closes #18089 from yanboliang/spark-19281.

(cherry picked from commit 913a6bf)
Signed-off-by: Yanbo Liang <ybliang8@gmail.com>
@asfgit asfgit closed this in 913a6bf May 25, 2017
@yanboliang yanboliang deleted the spark-19281 branch May 25, 2017 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants