[SPARK-19659][CORE][FOLLOW-UP] Fetch big blocks to disk when shuffle-read #18117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jinxing64 |
|
Test build #77415 has started for PR 18117 at commit |
|
retest this please |
|
Test build #77416 has finished for PR 18117 at commit
|
|
retest this please |
jinxing64
reviewed
May 26, 2017
| // TODO: Encryption and compression should be considered. | ||
| // Fetch remote shuffle blocks to disk when the request is too large. Since the shuffle data is | ||
| // already encrypted and compressed over the wire(w.r.t. the related configs), we can just fetch | ||
| // the data and write it to file directly. |
There was a problem hiding this comment.
I think this change is really good. Sorry for my ambiguous.
jinxing64
reviewed
May 26, 2017
| def fetchShuffleBlock(blocksByAddress: Seq[(BlockManagerId, Seq[(BlockId, Long)])]): Unit = { | ||
| // Set `maxBytesInFlight` and `maxReqsInFlight` to `Int.MaxValue`, so that during the | ||
| // construction of `ShuffleBlockFetcherIterator`, all requests to fetch remote shuffle blocks | ||
| // are issued. The `maxReqSizeShuffleToMem` is hard-coded as 200 here. |
|
@cloud-fan |
|
Test build #77425 has finished for PR 18117 at commit
|
|
thanks for the review, merging to master/2.2! |
asfgit
pushed a commit
that referenced
this pull request
May 27, 2017
…read ## What changes were proposed in this pull request? This PR includes some minor improvement for the comments and tests in #16989 ## How was this patch tested? N/A Author: Wenchen Fan <wenchen@databricks.com> Closes #18117 from cloud-fan/follow. (cherry picked from commit 1d62f8a) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR includes some minor improvement for the comments and tests in #16989
How was this patch tested?
N/A