Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mllib] DecisionTree Strategy parameter checks #1821

Closed
wants to merge 2 commits into from
Closed

[mllib] DecisionTree Strategy parameter checks #1821

wants to merge 2 commits into from

Conversation

jkbradley
Copy link
Member

Added some checks to Strategy to print out meaningful error messages when given invalid DecisionTree parameters.
CC @mengxr

@SparkQA
Copy link

SparkQA commented Aug 7, 2014

QA tests have started for PR 1821. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18090/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 7, 2014

QA results for PR 1821:
- This patch FAILED unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18090/consoleFull

@mengxr
Copy link
Contributor

mengxr commented Aug 7, 2014

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Aug 7, 2014

QA tests have started for PR 1821. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18101/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 7, 2014

QA results for PR 1821:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18101/consoleFull

asfgit pushed a commit that referenced this pull request Aug 7, 2014
@jkbradley @mengxr
[mllib] DecisionTree Strategy parameter checks
c089429 
Added some checks to Strategy to print out meaningful error messages when given invalid DecisionTree parameters.
CC mengxr

Author: Joseph K. Bradley <joseph.kurata.bradley@gmail.com>

Closes #1821 from jkbradley/dt-robustness and squashes the following commits:

4dc449a [Joseph K. Bradley] Merge remote-tracking branch 'upstream/master' into dt-robustness
7a61f7b [Joseph K. Bradley] Added some checks to Strategy to print out meaningful error messages when given invalid DecisionTree parameters

(cherry picked from commit 8d1dec4)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@asfgit asfgit closed this in 8d1dec4 Aug 7, 2014
@mengxr
Copy link
Contributor

mengxr commented Aug 7, 2014

LGTM. Merged into both master and branch-1.1. Thanks!

xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@jkbradley @conviva-zz
[mllib] DecisionTree Strategy parameter checks
f070f3d 
Added some checks to Strategy to print out meaningful error messages when given invalid DecisionTree parameters.
CC mengxr

Author: Joseph K. Bradley <joseph.kurata.bradley@gmail.com>

Closes apache#1821 from jkbradley/dt-robustness and squashes the following commits:

4dc449a [Joseph K. Bradley] Merge remote-tracking branch 'upstream/master' into dt-robustness
7a61f7b [Joseph K. Bradley] Added some checks to Strategy to print out meaningful error messages when given invalid DecisionTree parameters
@jkbradley jkbradley deleted the dt-robustness branch October 8, 2014 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jkbradley @SparkQA @mengxr