Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-21064][Core][Test] Fix the default value bug in NettyBlockTransferServiceSuite #18280

Closed
wants to merge 1 commit into from
Closed

Conversation

libratiger
Copy link

What changes were proposed in this pull request?

The default value for spark.port.maxRetries is 100,
but we use 10 in the suite file.
So we change it to 100 to avoid test failure.

How was this patch tested?

No test

…sferServiceSuite

The defalut value for `spark.port.maxRetries` is 100,
but we use 10 in the suite file.
@SparkQA
Copy link

SparkQA commented Jun 13, 2017

Test build #3795 has finished for PR 18280 at commit 273f76d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Jun 13, 2017
…sferServiceSuite

## What changes were proposed in this pull request?

The default value for `spark.port.maxRetries` is 100,
but we use 10 in the suite file.
So we change it to 100 to avoid test failure.

## How was this patch tested?
No test

Author: DjvuLee <lihu@bytedance.com>

Closes #18280 from djvulee/NettyTestBug.

(cherry picked from commit b36ce2a)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@srowen
Copy link
Member

srowen commented Jun 13, 2017

Merged to master/2.2/2.1

@asfgit asfgit closed this in b36ce2a Jun 13, 2017
asfgit pushed a commit that referenced this pull request Jun 13, 2017
…sferServiceSuite

## What changes were proposed in this pull request?

The default value for `spark.port.maxRetries` is 100,
but we use 10 in the suite file.
So we change it to 100 to avoid test failure.

## How was this patch tested?
No test

Author: DjvuLee <lihu@bytedance.com>

Closes #18280 from djvulee/NettyTestBug.

(cherry picked from commit b36ce2a)
Signed-off-by: Sean Owen <sowen@cloudera.com>
dataknocker pushed a commit to dataknocker/spark that referenced this pull request Jun 16, 2017
…sferServiceSuite

## What changes were proposed in this pull request?

The default value for `spark.port.maxRetries` is 100,
but we use 10 in the suite file.
So we change it to 100 to avoid test failure.

## How was this patch tested?
No test

Author: DjvuLee <lihu@bytedance.com>

Closes apache#18280 from djvulee/NettyTestBug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants